Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util goovn TLS connection need to use the latest rotated certificates #563

Closed
wants to merge 1 commit into from

Conversation

jluhrsen
Copy link
Contributor

@jluhrsen jluhrsen commented Jun 3, 2021

use fsnotify watcher to monitor ovndb-client private Key File and Cert
file changes. With goovn client initlized with reconnect flag true,
close the current connection with new TLS cerficate updated,
goovn underly rpc2client will reconnect with new TLS cerficates.

Signed-off-by: Zhen Wang zhewang@nvidia.com

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

use fsnotify watcher to monitor ovndb-client private Key File and Cert
file changes. With goovn client initlized with reconnect flag true,
close the current connection with new TLS cerficate updated,
goovn underly rpc2client will reconnect with new TLS cerficates.

Signed-off-by: Zhen Wang <zhewang@nvidia.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2021

@jluhrsen: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

util goovn TLS connection need to use the latest rotated certificates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Jun 3, 2021

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jluhrsen
To complete the pull request process, please assign danwinship after the PR has been reviewed.
You can assign the PR to them by writing /assign @danwinship in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from trozet and tssurya June 3, 2021 20:15
@jluhrsen
Copy link
Contributor Author

jluhrsen commented Jun 3, 2021

shot in the dark for https://bugzilla.redhat.com/show_bug.cgi?id=1961528

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2021

@jluhrsen: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovn-hybrid-step-registry a6b62d0 link /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-metal-ipi-ovn-dualstack a6b62d0 link /test e2e-metal-ipi-ovn-dualstack
ci/prow/okd-e2e-gcp-ovn a6b62d0 link /test okd-e2e-gcp-ovn
ci/prow/e2e-gcp-ovn-upgrade a6b62d0 link /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-windows a6b62d0 link /test e2e-aws-ovn-windows

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jluhrsen jluhrsen closed this Jun 29, 2021
@jluhrsen jluhrsen deleted the small-ssl-key-4.6 branch November 11, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants