Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1972253: CARRY: fix missed learn for hybrid exgw #575

Merged
merged 1 commit into from Jun 23, 2021
Merged

[release-4.6] Bug 1972253: CARRY: fix missed learn for hybrid exgw #575

merged 1 commit into from Jun 23, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #556

/assign trozet

@trozet
CARRY: fix missed learn for hybrid exgw
a497950 
We are intentionally ignoring learn when something critical to the learn
flow changes like pod ip, mac, exgw annotations. However, once we sync
flows we should reset the pod to learn the flow on the next sync.
However, we were only resetting pods for which we found flows already in
OVS. This fixes that by restting ignoreLearn for all pods as long as we
have a successful sync.

Signed-off-by: Tim Rozet <trozet@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 15, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

@openshift-cherrypick-robot: Bugzilla bug 1965075 has been cloned as Bugzilla bug 1972253. Retitling PR to link against new bug.
/retitle [release-4.6] [release-4.7] Bug 1972253: CARRY: fix missed learn for hybrid exgw

In response to this:

[release-4.6] [release-4.7] Bug 1965075: CARRY: fix missed learn for hybrid exgw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.6] [release-4.7] Bug 1965075: CARRY: fix missed learn for hybrid exgw [release-4.6] [release-4.7] Bug 1972253: CARRY: fix missed learn for hybrid exgw Jun 15, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jun 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1972253, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1965075 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1965075 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @mcornea

In response to this:

[release-4.6] [release-4.7] Bug 1972253: CARRY: fix missed learn for hybrid exgw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 15, 2021
@openshift-ci openshift-ci bot requested a review from mcornea June 15, 2021 14:00
@trozet
Copy link
Contributor

trozet commented Jun 15, 2021

/retitle [release-4.6] Bug 1972253: CARRY: fix missed learn for hybrid exgw

@openshift-ci openshift-ci bot changed the title [release-4.6] [release-4.7] Bug 1972253: CARRY: fix missed learn for hybrid exgw [release-4.6] Bug 1972253: CARRY: fix missed learn for hybrid exgw Jun 15, 2021
@trozet
Copy link
Contributor

trozet commented Jun 16, 2021

/retest

@alexanderConstantinescu
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
@trozet
Copy link
Contributor

trozet commented Jun 18, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderConstantinescu, openshift-cherrypick-robot, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2021
@trozet
Copy link
Contributor

trozet commented Jun 18, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 23, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f51d1b0 into openshift:release-4.6 Jun 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1972253 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1972253: CARRY: fix missed learn for hybrid exgw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship Awaiting requested review from danwinship

@juanluisvaladas juanluisvaladas Awaiting requested review from juanluisvaladas

@mcornea mcornea Awaiting requested review from mcornea

Assignees

@trozet trozet

@alexanderConstantinescu alexanderConstantinescu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @trozet @alexanderConstantinescu @openshift-bot @bparees @openshift-merge-robot