ovn: retry pod setup in update if it fails during add #58
Conversation
If a failure occurred during a pod Add the error would be logged but setup would never be retried because the pod would remain scheduled. Instead, use the 'ovn' annotation as a marker of whether the pod has been set up or not. Since setting the annotation should be the last thing we do, we can mostly use this as an indicator of setup success. Signed-off-by: Dan Williams <dcbw@redhat.com>
openshift-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@dcbw: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Failed tests seem like flakes and not network related: |
If a failure occurred during a pod Add the error would be logged
but setup would never be retried because the pod would remain
scheduled. Instead, use the 'ovn' annotation as a marker of
whether the pod has been set up or not. Since setting the annotation
should be the last thing we do, we can mostly use this as an
indicator of setup success.
Signed-off-by: Dan Williams dcbw@redhat.com