Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.8] Bug 1988487: Fix lgw eip 4.8 #636

Merged
merged 2 commits into from Aug 12, 2021
Merged

[release-4.8] Bug 1988487: Fix lgw eip 4.8 #636

merged 2 commits into from Aug 12, 2021

Conversation

astoycos
Copy link
Contributor

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Andrew Stoycos and others added 2 commits July 30, 2021 12:14
@astoycos
Simplify LGW IPtables
6773f31 
Make Iptables rule for every ExternalIP or ingress IP, this will
result in shortcirciting of node -> ExternalIP service traffic

Remove code to manage host routes

Ensure we cleanup any stale routes on upgrade

Signed-off-by: astoycos <astoycos@redhat.com>
@astoycos
Add test for EIP with new node IPs
9abaa60 
Add a test that validates an ExternalIP Service works
correctly even after a new node IP is manually added

Signed-off-by: astoycos <astoycos@redhat.com>
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 30, 2021

@astoycos: This pull request references Bugzilla bug 1988487, which is invalid:

  • expected dependent Bugzilla bug 1959798 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.8] Bug 1988487: Fix lgw eip 4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@astoycos
Copy link
Contributor Author

astoycos commented Aug 9, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2021

@astoycos: This pull request references Bugzilla bug 1988487, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1959798 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1959798 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@astoycos
Copy link
Contributor Author

astoycos commented Aug 9, 2021

/retest

@astoycos
Copy link
Contributor Author

/retest required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2021

@astoycos: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-local-gateway
  • /test e2e-aws-ovn-windows
  • /test e2e-azure-ovn
  • /test e2e-gcp-ovn-upgrade
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-ovn-hybrid-step-registry
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-windows
  • /test images
  • /test okd-images

The following commands are available to trigger optional jobs:

  • /test 4.8-upgrade-from-stable-4.7-e2e-aws-ovn-upgrade
  • /test e2e-gcp-ovn
  • /test e2e-metal-ipi-ovn-dualstack
  • /test okd-e2e-gcp-ovn

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-aws-ovn
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-aws-ovn-local-gateway
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-aws-ovn-windows
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-azure-ovn
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-gcp-ovn
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-metal-ipi-ovn-dualstack
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-ovn-hybrid-step-registry
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-vsphere-ovn
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-vsphere-windows
  • pull-ci-openshift-ovn-kubernetes-release-4.8-images
  • pull-ci-openshift-ovn-kubernetes-release-4.8-okd-e2e-gcp-ovn
  • pull-ci-openshift-ovn-kubernetes-release-4.8-okd-images

In response to this:

/retest required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@astoycos
Copy link
Contributor Author

/retest-required

@astoycos
Copy link
Contributor Author

/retest

3 similar comments
@astoycos
Copy link
Contributor Author

/retest

@astoycos
Copy link
Contributor Author

/retest

@astoycos
Copy link
Contributor Author

/retest

@abhat
Copy link
Contributor

abhat commented Aug 11, 2021

/override ci/prow/e2e-gcp-ovn-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@abhat: Overrode contexts on behalf of abhat: ci/prow/e2e-gcp-ovn-upgrade

In response to this:

/override ci/prow/e2e-gcp-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhat
Copy link
Contributor

abhat commented Aug 12, 2021

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, astoycos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2021
@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 12, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit d7ca616 into openshift:release-4.8 Aug 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

@astoycos: All pull requests linked via external trackers have merged:

Bugzilla bug 1988487 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 1988487: Fix lgw eip 4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhat abhat Awaiting requested review from abhat

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

Assignees

@abhat abhat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@astoycos @abhat @openshift-bot @bparees