Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1985957: Backport ovnkube-trace requires ip package to be installed to 4.8 #656

Merged
merged 2 commits into from Aug 19, 2021
Merged

Bug 1985957: Backport ovnkube-trace requires ip package to be installed to 4.8 #656

merged 2 commits into from Aug 19, 2021

Conversation

creydr
Copy link
Member

@creydr creydr commented Aug 12, 2021 •
edited

- What this PR does and why is it needed
This PR is a cherry-pick to backport 818e04b3 and 902c93a8 to 4.8.z, so that it is not required anymore for ovnkube-trace to have the ip package to be installed in the source/destination pods

- Special notes for reviewers
none

- How to verify it

  1. start a 4.8 cluster with this patch
  2. Follow https://access.redhat.com/solutions/5887511 with a source or destination pod that don't have iproute package on it (e.g. use an nginx image: k create deploy hello-world --image nginxinc/nginx-unprivileged --replicas 3)

- Description for the changelog
Remove ovnkube-trace requirement for ip package to be installed in source / destination pod

bostrt and others added 2 commits August 12, 2021 10:50
@bostrt @creydr
Check /sys/class/net for ifindex when ip command is not available ins…
60c98e1 
…ide Pod

Signed-off-by: Robert Bost <rbost@redhat.com>
@andreaskaris @creydr
ovnkube-trace: Refactor get linkIndex from /sys interface
a5273b5 
iproute is not guaranteed to be present in a pod. Simply always
retrieve the required linkIndex from the standard /sys interfaces
which will be present on all Linux pods. This is a refactor of an
earlier commit.

Also, for the ovnkube pod check, remove an else condition which was
never hit because tryJSON was always set to true.

Fixes #2307

Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

@creydr: This pull request references Bugzilla bug 1985957, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1978137 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1978137 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

In response to this:

Bug 1985957: Backport ovnkubetrace requires ip to be installed to 4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot requested review from trozet and tssurya August 12, 2021 09:10
@creydr creydr changed the title Bug 1985957: Backport ovnkubetrace requires ip to be installed to 4.8 Bug 1985957: Backport ovnkube-trace requires ip package to be installed to 4.8 Aug 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

@creydr: This pull request references Bugzilla bug 1985957, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1978137 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1978137 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

In response to this:

Bug 1985957: Backport ovnkube-trace requires ip package to be installed to 4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@creydr creydr marked this pull request as ready for review August 12, 2021 10:51
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2021
@creydr
Copy link
Member Author

creydr commented Aug 12, 2021

/retest

2 similar comments
@creydr
Copy link
Member Author

creydr commented Aug 13, 2021

/retest

@creydr
Copy link
Member Author

creydr commented Aug 13, 2021

/retest

@dcbw
Copy link
Contributor

dcbw commented Aug 13, 2021

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@deads2k deads2k added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 19, 2021
@deads2k
Copy link
Contributor

deads2k commented Aug 19, 2021

(patch manager)

medium bz, 0.7, aids in debugging

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c21ceac into openshift:release-4.8 Aug 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2021

@creydr: All pull requests linked via external trackers have merged:

Bugzilla bug 1985957 has been moved to the MODIFIED state.

In response to this:

Bug 1985957: Backport ovnkube-trace requires ip package to be installed to 4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@creydr
Copy link
Member Author

creydr commented Aug 20, 2021

/cherry-pick release-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 20, 2021
Merged
@openshift-cherrypick-robot
Copy link

@creydr: new pull request created: #674

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet Awaiting requested review from trozet

@tssurya tssurya Awaiting requested review from tssurya

Assignees

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@creydr @dcbw @openshift-bot @deads2k @openshift-cherrypick-robot @openshift-merge-robot @bostrt @andreaskaris