Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.8] Bug 2004336: Ensure host interfaces are deleted by CNI #745

Merged
merged 2 commits into from Sep 24, 2021
Merged

[release-4.8] Bug 2004336: Ensure host interfaces are deleted by CNI #745

merged 2 commits into from Sep 24, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #738

/assign dcbw

@trozet
Use ovsExec to delete pods
be15d92 
Signed-off-by: Tim Rozet <trozet@redhat.com>
@trozet
Ensure host interfaces are deleted by CNI
c9686e4 
Due to https://bugzilla.redhat.com/show_bug.cgi?id=2003193 where crio
is not cleaning up leftover veths/netns...overtime OVS CPU climbs to
100% and performance degrades in the node. This ensures OVN CNI cleans
up the ports rather than relying on kublet/crio.

Signed-off-by: Tim Rozet <trozet@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 15, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2021

@openshift-cherrypick-robot: Bugzilla bug 2003195 has been cloned as Bugzilla bug 2004336. Retitling PR to link against new bug.
/retitle [release-4.8] Bug 2004336: Ensure host interfaces are deleted by CNI

In response to this:

[release-4.8] Bug 2003195: Ensure host interfaces are deleted by CNI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.8] Bug 2003195: Ensure host interfaces are deleted by CNI [release-4.8] Bug 2004336: Ensure host interfaces are deleted by CNI Sep 15, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2004336, which is invalid:

  • expected dependent Bugzilla bug 2003195 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
  • expected dependent Bugzilla bug 2003195 to target a release in 4.9.0, but it targets "4.10.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.8] Bug 2004336: Ensure host interfaces are deleted by CNI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Member

dcbw commented Sep 15, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2021

@dcbw: This pull request references Bugzilla bug 2004336, which is invalid:

  • expected dependent Bugzilla bug 2004337 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trozet
Copy link
Contributor

trozet commented Sep 22, 2021

/retest

@dcbw
Copy link
Member

dcbw commented Sep 22, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2021
@dcbw
Copy link
Member

dcbw commented Sep 22, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2021

@dcbw: This pull request references Bugzilla bug 2004336, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2004337 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2004337 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Member

dcbw commented Sep 22, 2021

/retest e2e-metal-ipi-ovn-ipv6
2021-09-22 00:24:35 fatal: [localhost]: FAILED! => {"changed": false, "msg": "ERROR: Packet setup failed."}

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2021

@dcbw: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-local-gateway
  • /test e2e-aws-ovn-windows
  • /test e2e-azure-ovn
  • /test e2e-gcp-ovn-upgrade
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-ovn-hybrid-step-registry
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-windows
  • /test images
  • /test okd-images

The following commands are available to trigger optional jobs:

  • /test 4.8-upgrade-from-stable-4.7-e2e-aws-ovn-upgrade
  • /test e2e-gcp-ovn
  • /test e2e-metal-ipi-ovn-dualstack
  • /test okd-e2e-gcp-ovn

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-aws-ovn
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-aws-ovn-local-gateway
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-aws-ovn-windows
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-azure-ovn
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-gcp-ovn
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-metal-ipi-ovn-dualstack
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-ovn-hybrid-step-registry
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-vsphere-ovn
  • pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-vsphere-windows
  • pull-ci-openshift-ovn-kubernetes-release-4.8-images
  • pull-ci-openshift-ovn-kubernetes-release-4.8-okd-e2e-gcp-ovn
  • pull-ci-openshift-ovn-kubernetes-release-4.8-okd-images

In response to this:

/retest e2e-metal-ipi-ovn-ipv6
2021-09-22 00:24:35 fatal: [localhost]: FAILED! => {"changed": false, "msg": "ERROR: Packet setup failed."}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Member

dcbw commented Sep 22, 2021

/test e2e-metal-ipi-ovn-ipv6
2021-09-22 00:24:35 fatal: [localhost]: FAILED! => {"changed": false, "msg": "ERROR: Packet setup failed."}

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@dhellmann dhellmann added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 23, 2021
@dhellmann
Copy link

[patch-manager] 🚀 Approved for z-stream by score: 1.00

picked

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@trozet
Copy link
Contributor

trozet commented Sep 24, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1e460a9 into openshift:release-4.8 Sep 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2021

@openshift-cherrypick-robot: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2004336 has not been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 2004336: Ensure host interfaces are deleted by CNI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trozet trozet mentioned this pull request Sep 24, 2021
Closed
@trozet
Copy link
Contributor

trozet commented Sep 24, 2021

/cherry-pick release-4.7

@openshift-cherrypick-robot
Copy link
Author

@trozet: #745 failed to apply on top of branch "release-4.7":

Applying: Use ovsExec to delete pods
Applying: Ensure host interfaces are deleted by CNI
Using index info to reconstruct a base tree...
M	go-controller/pkg/cni/helper_linux.go
Falling back to patching base and 3-way merge...
Auto-merging go-controller/pkg/cni/helper_linux.go
CONFLICT (content): Merge conflict in go-controller/pkg/cni/helper_linux.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Ensure host interfaces are deleted by CNI
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anuragthehatter
Copy link

/lgtm
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship Awaiting requested review from danwinship

@trozet trozet Awaiting requested review from trozet

Assignees

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @dcbw @trozet @openshift-bot @dhellmann @anuragthehatter @openshift-merge-robot