Only build Windows binary on supported platforms #75
Conversation
openshift-ci-robot
added
the
size/S
|
@dcbw Windows is supported on ARM architectures as well...not sure if those should be supported as well here? |
|
I can also remove the windows directory after the noop copy, if we dont want a noop file/windows directory to even exist at all on unsupported arch. Just let me know. |
|
do we have any way to test that this actually does fix the s390x build? |
|
@danwinship I tested it in a negative scenario by using an unsupported arch and it built just fine. |
Patch changes docker building to only build windows on x86 platforms. Signed-off-by: Tim Rozet <trozet@redhat.com>
trozet
force-pushed
the
build_windows_only_x86_64
branch
from
4218dbb
to
db1e485
Compare
|
/test e2e-aws-ovn |
|
/retest |
1 similar comment
|
/retest |
|
|
||
| # only build windows on supported platforms | ||
| # otherwise create a dummy windows binary to allow subsequent COPY to still work | ||
| RUN if [[ $(arch) =~ ^(x86_64|i386)$ ]]; then \ |
There was a problem hiding this comment.
ugh... this is really ugly and I don't have any good suggestion on how to improve it, except that maybe this means we should not be building the windows binary here (since we don't actually need it to be in this image anyway and are only doing that as a hack).
There was a problem hiding this comment.
there is a PR to move it into its own image: #68
|
/lgtm if we don't come up with a better fix feel free to " |
openshift-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@trozet: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
closing in favor of #76 |
Patch changes docker building to only build windows on x86 platforms.
Signed-off-by: Tim Rozet trozet@redhat.com