WIP Fix image build

[danwinship]

No description provided.

[pecameron]

@danwinship I got tagged to review this. Is this work in progress? there is no description.
A note on kubectl vs oc: Guru doesn't like to see OpenShift specific anything in ovn. There was a spot where I couldn't figure out the kubectl equivalent of an oc. Considering the size of kubectl/oc it would be good to find a way to eliminate it.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[danwinship]

Is this work in progress?

Yes, hence the "WIP" in the title. (There is unfortunately no way, AFAIK, to get openshift-ci-bot to not tag people for review.)

A note on kubectl vs oc

In OpenShift they are they same binary. But the image we're grabbing it from only has /usr/bin/oc on disk, so we copy that over, and then symlink it to kubectl as well. So this isn't introducing any oc dependency, it's just getting an OpenShift-built kubectl binary into the OpenShift-built ovn-kubernetes image.

[pecameron]

@danwinship originally oc/kubernetes was not needed in the image and then we rearranged the install and got included. It would be great if didn't need it.

[openshift-ci-robot]

@danwinship: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws	3691e60	link	/test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[danwinship]

Currently ovnkube.sh requires kubectl. In fact, it requires kubectl in more places than it did 6 months ago. We can try to get rid of that dependency upstream, but for now, that dependency is there