Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 2015512: run RunDBChecker as goroutine #806

Closed
wants to merge 1 commit into from

Conversation

jluhrsen
Copy link
Contributor

when the ovn-dbchecker was receiving a SIGTERM it would
catch it, but the channel never closed so it never
quits.

Signed-off-by: Jamo Luhrsen jluhrsen@gmail.com

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

@jluhrsen
Copy link
Contributor Author

/test 4.10-upgrade-from-stable-4.8-images

1 similar comment
@jluhrsen
Copy link
Contributor Author

/test 4.10-upgrade-from-stable-4.8-images

@jluhrsen
Copy link
Contributor Author

/test 4.10-upgrade-from-stable-4.8

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2021

@jluhrsen: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test 4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade
  • /test 4.10-upgrade-from-stable-4.8-images
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-local-gateway
  • /test e2e-aws-ovn-windows
  • /test e2e-gcp-ovn
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test images
  • /test okd-images

The following commands are available to trigger optional jobs:

  • /test e2e-azure-ovn
  • /test e2e-openstack-ovn
  • /test e2e-ovn-hybrid-step-registry
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-windows
  • /test okd-e2e-gcp-ovn

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-ovn-kubernetes-master-4.10-upgrade-from-stable-4.8-images
  • pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn
  • pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-local-gateway
  • pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-windows
  • pull-ci-openshift-ovn-kubernetes-master-e2e-azure-ovn
  • pull-ci-openshift-ovn-kubernetes-master-e2e-gcp-ovn
  • pull-ci-openshift-ovn-kubernetes-master-e2e-metal-ipi-ovn-dualstack
  • pull-ci-openshift-ovn-kubernetes-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-ovn-kubernetes-master-e2e-openstack-ovn
  • pull-ci-openshift-ovn-kubernetes-master-e2e-ovn-hybrid-step-registry
  • pull-ci-openshift-ovn-kubernetes-master-e2e-vsphere-ovn
  • pull-ci-openshift-ovn-kubernetes-master-e2e-vsphere-windows
  • pull-ci-openshift-ovn-kubernetes-master-images
  • pull-ci-openshift-ovn-kubernetes-master-okd-e2e-gcp-ovn
  • pull-ci-openshift-ovn-kubernetes-master-okd-images

In response to this:

/test 4.10-upgrade-from-stable-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jluhrsen
Copy link
Contributor Author

/test 4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade

13 similar comments
@jluhrsen
Copy link
Contributor Author

/test 4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade

@jluhrsen
Copy link
Contributor Author

/test 4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade

@jluhrsen
Copy link
Contributor Author

/test 4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade

@jluhrsen
Copy link
Contributor Author

/test 4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade

@jluhrsen
Copy link
Contributor Author

/test 4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade

@jluhrsen
Copy link
Contributor Author

/test 4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade

@jluhrsen
Copy link
Contributor Author

/test 4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade

@jluhrsen
Copy link
Contributor Author

/test 4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Nov 1, 2021

/test 4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Nov 1, 2021

/test 4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Nov 2, 2021

/test 4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Nov 2, 2021

/test 4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Nov 2, 2021

/test 4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade

@jluhrsen jluhrsen changed the title run RunDBChecker as goroutine bug 2015512: run RunDBChecker as goroutine Nov 5, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Nov 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2021

@jluhrsen: This pull request references Bugzilla bug 2015512, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

bug 2015512: run RunDBChecker as goroutine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 5, 2021
when the ovn-dbchecker was receiving a SIGTERM it would
catch it, but the channel never closed so it never
quits.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@jluhrsen
Copy link
Contributor Author

jluhrsen commented Nov 5, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2021

@jluhrsen: This pull request references Bugzilla bug 2015512, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@trozet
Copy link
Contributor

trozet commented Nov 9, 2021

/override ci/prow/e2e-metal-ipi-ovn-ipv6

@trozet
Copy link
Contributor

trozet commented Nov 9, 2021

/override ci/prow/4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2021

@trozet: Cannot get PR #806 in openshift/ovn-kubernetes

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2021

@trozet: Overrode contexts on behalf of trozet: ci/prow/4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade

In response to this:

/override ci/prow/4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2021

@jluhrsen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn d7aa7e1 link false /test e2e-vsphere-ovn
ci/prow/e2e-azure-ovn d7aa7e1 link false /test e2e-azure-ovn
ci/prow/4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade d7aa7e1 link true /test 4.10-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-upgrade d7aa7e1 link true /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jluhrsen
Copy link
Contributor Author

This PR is messed up with the openshift-bot and required, or not, tests. closing it in favor of a new identical PR that I hope will behave better. 🤷🏻‍♂️

@jluhrsen jluhrsen closed this Nov 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2021

@jluhrsen: This pull request references Bugzilla bug 2015512. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

bug 2015512: run RunDBChecker as goroutine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jluhrsen jluhrsen deleted the goroutine-ovndbchecker branch November 11, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants