Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2024313: run RunDBChecker as goroutine #841

Closed

Conversation

jluhrsen
Copy link
Contributor

when the ovn-dbchecker was receiving a SIGTERM it would
catch it, but the channel never closed so it never
quits. Fix that.

Signed-off-by: Jamo Luhrsen jluhrsen@gmail.com

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

when the ovn-dbchecker was receiving a SIGTERM it would
catch it, but the channel never closed so it never
quits. Fix that.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@jluhrsen jluhrsen changed the title run RunDBChecker as goroutine Bug 2015512: run RunDBChecker as goroutine Nov 17, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Nov 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2021

@jluhrsen: This pull request references Bugzilla bug 2015512, which is invalid:

  • expected the bug to target the "4.9.z" release, but it targets "4.10.0" instead
  • expected Bugzilla bug 2015512 to depend on a bug targeting a release in 4.10.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2015512: run RunDBChecker as goroutine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2021

@jluhrsen: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

run RunDBChecker as goroutine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jluhrsen
To complete the pull request process, please assign trozet after the PR has been reviewed.
You can assign the PR to them by writing /assign @trozet in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jluhrsen jluhrsen changed the title Bug 2015512: run RunDBChecker as goroutine Bug 2024313: run RunDBChecker as goroutine Nov 17, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2021

@jluhrsen: This pull request references Bugzilla bug 2024313, which is invalid:

  • expected dependent Bugzilla bug 2015512 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2024313: run RunDBChecker as goroutine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2021

@jluhrsen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-windows 218c7d7 link false /test e2e-vsphere-windows
ci/prow/e2e-vsphere-ovn 218c7d7 link false /test e2e-vsphere-ovn
ci/prow/e2e-azure-ovn 218c7d7 link false /test e2e-azure-ovn
ci/prow/e2e-aws-ovn-local-gateway 218c7d7 link true /test e2e-aws-ovn-local-gateway
ci/prow/okd-e2e-gcp-ovn 218c7d7 link false /test okd-e2e-gcp-ovn
ci/prow/e2e-aws-ovn 218c7d7 link true /test e2e-aws-ovn
ci/prow/e2e-ovn-hybrid-step-registry 218c7d7 link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-metal-ipi-ovn-dualstack 218c7d7 link true /test e2e-metal-ipi-ovn-dualstack
ci/prow/4.9-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade 218c7d7 link false /test 4.9-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jluhrsen
Copy link
Contributor Author

this made it in as part of a u/s->d/s merge

@jluhrsen jluhrsen closed this Dec 11, 2021
@jluhrsen jluhrsen deleted the ovndbchecker-as-goroutine branch May 6, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant