Ensure downstream CI can run envtest successfully #72
Conversation
Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: timflannagan <timflannagan@gmail.com>
openshift-ci
bot
added
the
approved
| @@ -113,9 +113,10 @@ lint: golangci-lint | |||
| GOLANGCI_LINT_CACHE=/tmp/golangci-cache $(GOLANGCI_LINT) run | |||
|
|
|||
| UNIT_TEST_DIRS=$(shell go list ./... | grep -v /test/) | |||
| ENVTEST_OPTS ?= $(if $(OPENSHIFT_CI),--bin-dir=/tmp) | |||
There was a problem hiding this comment.
I realize that OPENSHIFT_CI could be set to "false" as we're not checking the value of that variable. That said, the existence of this variable should be sufficient for now given local environments are likely setting it, and CI is guaranteed to have it specified.
|
This doesn't affect anything user facing, and only affects our dev testing suite. Manually the requisite labels. /label px-approved |
openshift-ci
bot
added
px-approved
| CRDDirectoryPaths: []string{filepath.Join("..", "config", "crd", "bases")}, | ||
| CRDDirectoryPaths: []string{"../manifests", "../vendor/github.com/openshift/api/config/v1/"}, |
There was a problem hiding this comment.
Why did you choose to remove the filepath.Join call?
There was a problem hiding this comment.
Or rather, why abandon using filepath.Join.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@timflannagan: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Closes #70.
Updates the Makefile invocation when running the unit tests to ensure we're able to install the requisite envtest executables in a directory path that's writable in CI. Add a barebones testing suite to ensure we're not regressing on envtest capability.