Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-20861: Bump golang.org/x/net to v0.17.0 #248

Merged
merged 3 commits into from Nov 8, 2023
Merged

[release-4.13] OCPBUGS-20861: Bump golang.org/x/net to v0.17.0 #248

merged 3 commits into from Nov 8, 2023

Conversation

slashpai
Copy link
Member

No description provided.

@slashpai
OCPBUGS-20861: Bump golang.org/x/net to v0.17.0
9962117 
Signed-off-by: Jayapriya Pai <janantha@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 16, 2023
@openshift-ci-robot
Copy link

@slashpai: This pull request references Jira Issue OCPBUGS-20861, which is invalid:

  • expected dependent Jira Issue OCPBUGS-20881 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 16, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023
@simonpasquier
Copy link

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 16, 2023
@simonpasquier
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@slashpai slashpai changed the title OCPBUGS-20861: Bump golang.org/x/net to v0.17.0 [release-4.14] OCPBUGS-20861: Bump golang.org/x/net to v0.17.0 Oct 17, 2023
@slashpai slashpai changed the title [release-4.14] OCPBUGS-20861: Bump golang.org/x/net to v0.17.0 [release-4.13] OCPBUGS-20861: Bump golang.org/x/net to v0.17.0 Oct 17, 2023
@slashpai
Copy link
Member Author

/retest

@slashpai
Copy link
Member Author

/Jira refresh

@openshift-ci-robot
Copy link

@slashpai: This pull request references Jira Issue OCPBUGS-20861, which is invalid:

  • expected dependent Jira Issue OCPBUGS-20881 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/Jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@slashpai
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

@slashpai: This pull request references Jira Issue OCPBUGS-20861, which is invalid:

  • expected dependent Jira Issue OCPBUGS-20881 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@slashpai
Copy link
Member Author

/test e2e-agnostic-cmo

raptorsun
raptorsun approved these changes Oct 17, 2023
View reviewed changes
Copy link

@raptorsun raptorsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest-required

@slashpai
Copy link
Member Author

/test e2e-agnostic-cmo

@slashpai
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 18, 2023
@openshift-ci-robot
Copy link

@slashpai: This pull request references Jira Issue OCPBUGS-20861, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-20881 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-20881 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from juzhao October 18, 2023 06:20
@slashpai
Copy link
Member Author

/test e2e-agnostic-cmo

@slashpai
Copy link
Member Author

/retest

@juzhao
Copy link

juzhao commented Oct 25, 2023

/test e2e-agnostic-cmo

@juzhao
Copy link

juzhao commented Oct 27, 2023

/test e2e-agnostic-cmo

@juzhao
Copy link

juzhao commented Oct 27, 2023

prometheus-operator-admission-webhook still support HTTP2, detail see from bug comment

@slashpai
OCPBUGS-20861: disable HTTP2 connections by default
4b4a2a1 
Backporting prometheus-operator#6028

Signed-off-by: Jayapriya Pai <janantha@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2023
@slashpai
fix: remove verbose logging admission-webhook
f43b281 
After disabling HTTP2 connections by default in prometheus-operator#6028
started seeing verbose logging in admission webhook pods like:

`ts=2023-11-06T01:50:34.601774794Z caller=stdlib.go:105 caller=server.go:3215 msg="http: superfluous response.WriteHeader call from main.newSrv.func1 (main.go:173)"
`

Go doc says If WriteHeader is not called explicitly,
the first call to Write will trigger an implicit
WriteHeader(http.StatusOK).

This fix is to change the order of the method invocation
so log doesn't complain about this

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
(cherry picked from commit 374f4b3)
@slashpai
Copy link
Member Author

slashpai commented Nov 7, 2023

/Jira refresh

@openshift-ci-robot
Copy link

@slashpai: This pull request references Jira Issue OCPBUGS-20861, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-20881 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-20881 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

Requesting review from QA contact:
/cc @juzhao

In response to this:

/Jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@slashpai
Copy link
Member Author

slashpai commented Nov 7, 2023

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 7, 2023

@slashpai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@slashpai
Copy link
Member Author

slashpai commented Nov 7, 2023

@simonpasquier could you please review again

@juzhao
Copy link

juzhao commented Nov 7, 2023

/label cherry-pick-approved
/label qe-approved

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. qe-approved Signifies that QE has signed off on this PR labels Nov 7, 2023
@openshift-ci-robot
Copy link

@slashpai: This pull request references Jira Issue OCPBUGS-20861, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-20881 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-20881 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

Requesting review from QA contact:
/cc @juzhao

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@raptorsun
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raptorsun, simonpasquier, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [raptorsun,simonpasquier,slashpai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 30fdccd into openshift:release-4.13 Nov 8, 2023
7 checks passed
@openshift-ci-robot
Copy link

@slashpai: Jira Issue OCPBUGS-20861: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20861 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build prometheus-config-reloader-container-v4.13.0-202311211131.p0.g30fdccd.assembly.stream for distgit prometheus-config-reloader.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raptorsun raptorsun raptorsun approved these changes

@JoaoBraveCoding JoaoBraveCoding Awaiting requested review from JoaoBraveCoding

@juzhao juzhao Awaiting requested review from juzhao

Assignees

@simonpasquier simonpasquier

@raptorsun raptorsun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@slashpai @openshift-ci-robot @simonpasquier @juzhao @raptorsun @openshift-bot