New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.12] OCPBUGS-20843: Bump golang.org/x/net to v0.17.0 #249
[release-4.12] OCPBUGS-20843: Bump golang.org/x/net to v0.17.0 #249
Conversation
Signed-off-by: Jayapriya Pai <janantha@redhat.com>
@slashpai: This pull request references Jira Issue OCPBUGS-20843, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label backport-risk-assessed |
/lgtm |
Backporting prometheus-operator#6028 Signed-off-by: Jayapriya Pai <janantha@redhat.com>
/lgtm |
After disabling HTTP2 connections by default in prometheus-operator#6028 started seeing verbose logging in admission webhook pods like: `ts=2023-11-06T01:50:34.601774794Z caller=stdlib.go:105 caller=server.go:3215 msg="http: superfluous response.WriteHeader call from main.newSrv.func1 (main.go:173)" ` Go doc says If WriteHeader is not called explicitly, the first call to Write will trigger an implicit WriteHeader(http.StatusOK). This fix is to change the order of the method invocation so log doesn't complain about this Signed-off-by: Jayapriya Pai <slashpai9@gmail.com> (cherry picked from commit 374f4b3)
@slashpai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raptorsun, simonpasquier, slashpai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@slashpai: This pull request references Jira Issue OCPBUGS-20843, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@slashpai: This pull request references Jira Issue OCPBUGS-20843, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@juzhao: This pull request references Jira Issue OCPBUGS-20843, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label cherry-pick-approved |
@slashpai: This pull request references Jira Issue OCPBUGS-20843, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/label cherry-pick-approved |
d1e399d
into
openshift:release-4.12
@slashpai: Jira Issue OCPBUGS-20843: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-20843 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix included in accepted release 4.12.0-0.nightly-2023-11-09-162024 |
[ART PR BUILD NOTIFIER] This PR has been included in build prometheus-config-reloader-container-v4.12.0-202311220908.p0.gd1e399d.assembly.stream for distgit prometheus-config-reloader. |
No description provided.