Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-24323: Bump openshift/prometheus-operator to v0.70.0 #263

Merged
merged 82 commits into from Dec 1, 2023

Conversation

simonpasquier
Copy link

Taking over #262

dependabot bot and others added 30 commits November 6, 2023 12:37
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.4.0 to 0.5.0.
- [Commits](golang/sync@v0.4.0...v0.5.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…dependabot/go_modules/golang.org/x/sync-0.5.0

build(deps): bump golang.org/x/sync from 0.4.0 to 0.5.0
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.17.0 to 0.18.0.
- [Commits](golang/net@v0.17.0...v0.18.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…dependabot/go_modules/golang.org/x/net-0.18.0

build(deps): bump golang.org/x/net from 0.17.0 to 0.18.0
…loader-probes

add flag to enable liveness and readiness for the config-reloader container from jsonnet
The k8s client reloads the TLS files periodically and complains if they
have been removed.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
…ools

chore: update tool versions in scripts/go.mod
* config-reloader: change stderr to stdout

Changed all stderr logs to stdout and include levels too

* config-reloader: remove comment line

Remove comment live

* promcfg: change stderr to stdout

Changed on line 70 to os.Stdout
add service, pod, endpoints, endpointslice and ingress roles
to KubernetesSDConfigs in ScrapeConfig CRD

Fixes prometheus-operator#6086

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
…n-external

chore: remove TLS files only on exit
Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
The secrets and configmaps informers only need to store the name,
namespace and resource version of the objects: the event handlers don't
look at the other metadata fields. By stripping the rest of the
metadata, we can save a fair share of memory on clusters with lots of
secrets/configmaps.

Experiments show that the maximum memory usage with/without the change
is similar but once the situation settles, we have a ~80% decrease in
memory usage with this commit (from 300MB -> 50MB). More details (with
graphs) in the pull request.

To take full advantage of this optimization, we also tune the GOGC
variable to "30" to reclaim the memory faster after startup.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
.github/workflows: skip unit and e2e tests for *.md file updates
feat: support remaining roles in kubernetesSD
Fixes prometheus-operator#6077

Related-to prometheus-operator#5509

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
…ze-metadata-informers

feat: optimize memory usage of secret/configmap informers
feat: Add support for Azure SD in ScrapeConfig CRD
Bumps [github.com/prometheus/prometheus](https://github.com/prometheus/prometheus) from 0.47.2 to 0.48.0.
- [Release notes](https://github.com/prometheus/prometheus/releases)
- [Changelog](https://github.com/prometheus/prometheus/blob/main/CHANGELOG.md)
- [Commits](prometheus/prometheus@v0.47.2...v0.48.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/prometheus
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/alecthomas/kingpin/v2](https://github.com/alecthomas/kingpin) from 2.3.2 to 2.4.0.
- [Release notes](https://github.com/alecthomas/kingpin/releases)
- [Commits](alecthomas/kingpin@v2.3.2...v2.4.0)

---
updated-dependencies:
- dependency-name: github.com/alecthomas/kingpin/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…dependabot/go_modules/github.com/prometheus/prometheus-0.48.0

build(deps): bump github.com/prometheus/prometheus from 0.47.2 to 0.48.0
…dependabot/go_modules/github.com/alecthomas/kingpin/v2-2.4.0

build(deps): bump github.com/alecthomas/kingpin/v2 from 2.3.2 to 2.4.0
some of the json tags were not following
Kubernetes conventions

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
Related-to prometheus-operator#6080

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
* Share parsing for the logging flags across all binaries.
* Refactor and share the web server implementation between the operator
  and the admission webhook.
* Refactor controller configuration structs to include only the required
  parameters.
* Parse label and field selector arguments early instead of doing it in
  each controller.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2023
@simonpasquier simonpasquier changed the title Bump openshift/prometheus-operator to v0.70.0 OCPBUGS-24323: Bump openshift/prometheus-operator to v0.70.0 Dec 1, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 1, 2023
@openshift-ci-robot
Copy link

@simonpasquier: This pull request references Jira Issue OCPBUGS-24323, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Taking over #262

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonpasquier
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 1, 2023
@openshift-ci-robot
Copy link

@simonpasquier: This pull request references Jira Issue OCPBUGS-24323, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from juzhao December 1, 2023 10:21
The "slices" package is only available starting with Go 1.21. We can
remove this patch when the downstream Go is updated to 1.21.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
tls.VersionName() is only available starting with Go 1.21. We can remove
this patch when the downstream Go is updated to 1.21.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Copy link

openshift-ci bot commented Dec 1, 2023

@simonpasquier: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@slashpai
Copy link
Member

slashpai commented Dec 1, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2023
Copy link

openshift-ci bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [simonpasquier,slashpai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b558bb3 into openshift:master Dec 1, 2023
7 checks passed
@openshift-ci-robot
Copy link

@simonpasquier: Jira Issue OCPBUGS-24323: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-24323 has been moved to the MODIFIED state.

In response to this:

Taking over #262

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build prometheus-config-reloader-container-v4.15.0-202312012031.p0.gb558bb3.assembly.stream for distgit prometheus-config-reloader.
All builds following this will include this PR.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.15.0-0.nightly-2023-12-02-123536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet