New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TLS config for prometheus-operator #65
Add TLS config for prometheus-operator #65
Conversation
This allows tests to be run against functions in Main without conflicting between test flags and application flags. More info: golang/go#31859
Instead of converting between a map and slice (and back to map again in some cases), just use a map throughout.
Adds periodic certificate reload for operator web server TLS, and adds basic e2e test.
If a TLS certificate fails to reload, the operator should not exit. Just print a warning and continue checking the certificate at the reload interval.
Add CLI flag for activating web server TLS. Always use reloader for reading TLS certificates instead of loading manually at startup.
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilic, pgier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Backport of prometheus-operator#3134
Related to https://issues.redhat.com/browse/MON-857