New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1829501: fix TLS cli parameters #67
Bug 1829501: fix TLS cli parameters #67
Conversation
Use the local flagset for the variables and make the naming consistent with the other web tls settings.
5511b46
to
ab90f46
Compare
/retest |
@pgier: This pull request references Bugzilla bug 1829501, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@pgier: This pull request references Bugzilla bug 1829501, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @lilic This PR makes a couple of changes to CLI args, which normally I'd avoid, but we changed them upstream because there wasn't any release yet with the previous args. Hopefully, we can merge this before 4.5 just to prevent any chance of releasing prometheus-operator with different CLI args than upstream. WDYT? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pgier, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pgier: All pull requests linked via external trackers have merged: openshift/prometheus-operator#67. Bugzilla bug 1829501 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Backport of prometheus-operator#3157