Bug 1832124: retain pvc metdata

[pgier]

Backport of upstream PVC metadata fix: prometheus-operator#3115

[openshift-ci-robot]

@pgier: This pull request references Bugzilla bug 1832124, which is invalid:

• expected Bugzilla bug 1832124 to depend on a bug targeting a release in 4.5.0, 4.5.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1832124: retain pvc metdata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@pgier: This pull request references Bugzilla bug 1832124, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1832124: retain pvc metdata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pgier]

/bugzilla refresh

[openshift-ci-robot]

@pgier: This pull request references Bugzilla bug 1832124, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[s-urbaniak]

@pgier the upgrade test failure seems to be legit:

    <*errors.errorString | 0xc001a6c0c0>: {
        s: "Cluster did not complete upgrade: timed out waiting for the condition: Cluster operator monitoring is still updating",
    }
    Cluster did not complete upgrade: timed out waiting for the condition: Cluster operator monitoring is still updating

with an underlying error:

May 08 18:20:47.407 E ns/openshift-monitoring pod/prometheus-k8s-1 node/ip-10-0-137-167.ec2.internal container=prometheus-config-reloader container exited with code 2 (Error): ts=2020-05-08T18:19:42.391007353Z caller=main.go:85 msg="Starting prometheus-config-reloader version '1.12.16'."\nlevel=info ts=2020-05-08T18:19:42.391133303Z caller=reloader.go:127 msg="started watching config file for changes" in=/etc/prometheus/config/prometheus.yaml.gz out=/etc/prometheus/config_out/prometheus.env.yaml\nlevel=error ts=2020-05-08T18:19:42.392521749Z caller=runutil.go:87 msg="function failed. Retrying in next tick" err="trigger reload: reload request failed: Post http://localhost:9090/-/reload: dial tcp [::1]:9090: connect: connection refused"\nlevel=error ts=2020-05-08T18:19:47.392715916Z caller=runutil.go:87 msg="function failed. Retrying in next tick" err="trigger reload: reload request failed: Post http://localhost:9090/-/reload: dial tcp [::1]:9090: connect: connection refused"\nlevel=info ts=2020-05-08T18:19:52.504768465Z caller=reloader.go:258 msg="Prometheus reload triggered" cfg_in=/etc/prometheus/config/prometheus.yaml.gz cfg_out=/etc/prometheus/config_out/prometheus.env.yaml rule_dirs=\n

[lilic]

I would prefer this bugfix merged into the release branch of prom-operator upstream as we are not the only ones impacted by this and then brought in downstream to openshift.

[pgier]

Upstream PR to 0.38 release branch prometheus-operator#3209

[pgier]

/retest

[pgier]

@s-urbaniak I think it was just a flake, looks like it's passing now. @lilic I created an upstream PR, but I'm having trouble getting it to build correctly for some reason.

[pgier]

@s-urbaniak @lilic is this ok to merge now that the upstream issue is merged? or do we need an upstream Z release?

[s-urbaniak]

my 2 cent: if the content of the cherry-picks is the same as upstream i am fine with merging this. since the QA phase for 4.5 is not over yet we might encounter additional necessary fixes. Once 4.5 code freezes we can cut a z-release upstream.

[s-urbaniak]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pgier, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pgier,s-urbaniak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@pgier: All pull requests linked via external trackers have merged: openshift/prometheus-operator#68. Bugzilla bug 1832124 has been moved to the MODIFIED state.

In response to this:

Bug 1832124: retain pvc metdata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.