Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2019198:Rename Prometheus metrics in alert rules #154

Merged
merged 1 commit into from Dec 1, 2021
Merged

Bug 2019198:Rename Prometheus metrics in alert rules #154

merged 1 commit into from Dec 1, 2021

Conversation

aneeshkp
Copy link
Contributor

Signed-off-by: Aneesh Puttur aneeshputtur@gmail.com
Depends on openshift/linuxptp-daemon#58
Address the Bug, fixes renaming of offset metrics. Once the above linuxptp-daemon is merged, this PR fixed the alert rules naming

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2021

@aneeshkp: This pull request references Bugzilla bug 2019198, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @marzianor9

In response to this:

Bug 2019198:Rename Prometheus metrics in alter rules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2021

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: marzianor9.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@aneeshkp: This pull request references Bugzilla bug 2019198, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @marzianor9

In response to this:

Bug 2019198:Rename Prometheus metrics in alter rules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SchSeba
Copy link
Contributor

SchSeba commented Nov 17, 2021

/cc @josephdrichard

please help me reviewing this PR

@aneeshkp aneeshkp changed the title Bug 2019198:Rename Prometheus metrics in alter rules Bug 2019198:Rename Prometheus metrics in alert rules Nov 18, 2021
@aneeshkp
Fix metrics name
800f63b 
Signed-off-by: Aneesh Puttur <aneeshputtur@gmail.com>
SchSeba
SchSeba reviewed Nov 30, 2021
View reviewed changes
Copy link
Contributor

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, SchSeba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 27df244 into openshift:master Dec 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2021

@aneeshkp: Bugzilla bug 2019198 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Bug 2019198:Rename Prometheus metrics in alert rules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aneeshkp aneeshkp deleted the rename-metrix branch February 17, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchSeba SchSeba SchSeba left review comments

@dcbw dcbw Awaiting requested review from dcbw

@zshi-redhat zshi-redhat Awaiting requested review from zshi-redhat

@josephdrichard josephdrichard Awaiting requested review from josephdrichard

Assignees

@SchSeba SchSeba

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aneeshkp @SchSeba @openshift-bot @openshift-merge-robot