Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-22934: PTP operator needs infrastructure annotations to pass CVP tests #396

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

jzding
Copy link
Contributor

@jzding jzding commented Nov 1, 2023

No description provided.

Signed-off-by: Jack Ding <jackding@gmail.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2023
@aneeshkp
Copy link
Contributor

aneeshkp commented Nov 3, 2023

/retitle OCPBUGS-22934: PTP operator needs infrastructure annotations to pass CVP tests

@openshift-ci openshift-ci bot changed the title add new infra annotations OCPBUGS-22934: PTP operator needs infrastructure annotations to pass CVP tests Nov 3, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 3, 2023
@openshift-ci-robot
Copy link
Contributor

@jzding: This pull request references Jira Issue OCPBUGS-22934, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gsr-shanks

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aneeshkp
Copy link
Contributor

aneeshkp commented Nov 3, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2023
@aneeshkp
Copy link
Contributor

aneeshkp commented Nov 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2023
@aneeshkp
Copy link
Contributor

aneeshkp commented Nov 6, 2023

/unhold

Copy link
Contributor

@aneeshkp aneeshkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2023
Copy link
Contributor

openshift-ci bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, jzding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 6, 2023

@jzding: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit beeb3df into openshift:master Nov 6, 2023
7 checks passed
@openshift-ci-robot
Copy link
Contributor

@jzding: Jira Issue OCPBUGS-22934: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-22934 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jzding
Copy link
Contributor Author

jzding commented Nov 7, 2023

/cherry-pick release-4.14

@openshift-cherrypick-robot

@jzding: #396 failed to apply on top of branch "release-4.14":

Applying: add new infra annotations
Using index info to reconstruct a base tree...
M	bundle/manifests/ptp-operator.clusterserviceversion.yaml
M	config/manifests/bases/ptp-operator.clusterserviceversion.yaml
M	manifests/stable/ptp-operator.clusterserviceversion.yaml
Falling back to patching base and 3-way merge...
Auto-merging manifests/stable/ptp-operator.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in manifests/stable/ptp-operator.clusterserviceversion.yaml
Auto-merging config/manifests/bases/ptp-operator.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in config/manifests/bases/ptp-operator.clusterserviceversion.yaml
Auto-merging bundle/manifests/ptp-operator.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in bundle/manifests/ptp-operator.clusterserviceversion.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add new infra annotations
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jzding jzding deleted the infra-annotations branch February 8, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants