Check for Image in config object #6
Conversation
views/image-body.html
Outdated
| @@ -19,8 +19,8 @@ | |||
| <dd ng-if="!labels['build-date'] && !layers[0].v1Compatibility.created && image.dockerImageMetadata.Created" title="{{image.dockerImageMetadata.Created}}">{{image.dockerImageMetadata.Created | dateRelative}}</dd> | |||
| <dt translate>Digest</dt> | |||
| <dd><tt>{{ image.metadata.name }}</tt></dd> | |||
| <dt translate>Identifier</dt> | |||
| <dd><tt>{{ config.Image }}</tt></dd> | |||
| <dt ng-if="config.Image" translate>Identifier</dt> | |||
There was a problem hiding this comment.
use ng-if-start and ng-if-end instead of duplicating the if check
There was a problem hiding this comment.
yeah, was thinking about it, but we use the same (dup.) logic on other places in this file so want sure which one to use.
Will update
|
@jwforres @stefwalter updated |
|
change LGTM, not sure if @stefwalter had a merge queue or tests set up for this repo, guessing no? |
|
Smoke tested this manually by editing So @jwforres is Origin including even less information about Docker images now? I guess that'll affect the registry console and display of images in OWC, correct? @jhadvig Could you point to the exact change in origin that this is a result of? |
|
@stefwalter I guess @mfojtik will have more info about that |
|
@stefwalter the manifest removal is here: openshift/origin#11925 |
There was a bug opened that Identifier value is not set in the console.
Was talking to @mfojtik and he said that we are not setting the
Imageattribute in theImageConfigsince 1.4@stefwalter PTAL