This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
server.rb: fixes incorrect error output and additional input validation #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
|
Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/8959/) |
|
It looks like the test failures here are also unrelated and due to the same gherkin3 issue as #708 A requirement of a gem likely added the requirement of gherkin3. I beleive gherkin2 was used previously, which worked fine with ruby-1.8.7 |
Bug 1155003 Bugzilla link https://bugzilla.redhat.com/show_bug.cgi?id=1155003 Changes usage messages to include --ssl-client-key-file option, which was previously missing. The rhc server add command also requires all three of --ssl-ca-file, --ssl-client-cert-file, and ssl-client-key-file and will now raise an error if only 1 or 2 of the 3 are present. Adds corresponding spec test.
thrasher-redhat
force-pushed
the
bug1155003
branch
from
29a9f58
to
04fd726
Compare
|
Evaluated for online test up to 04fd726 |
|
This should be good to [merge] |
|
openshift-bot, please [merge]! |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6596/) (Image: devenv_5683) |
|
Evaluated for online merge up to 04fd726 |
openshift-bot
pushed a commit
that referenced
this pull request
Oct 26, 2015
Merged by openshift-bot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1155003
Bugzilla link https://bugzilla.redhat.com/show_bug.cgi?id=1155003
Changes usage messages to include --ssl-client-key-file option, which was previously missing.
The rhc server add command also requires all three of --ssl-ca-file, --ssl-client-cert-file, and ssl-client-key-file and will now raise an error if only 1 or 2 of the 3 are present.