Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1883398: ceph: update csi sidecar images #126

Merged
merged 1 commit into from Oct 1, 2020
Merged

Bug 1883398: ceph: update csi sidecar images #126

merged 1 commit into from Oct 1, 2020

Conversation

agarwal-mudit
Copy link
Member

This PR makes the changes in csi templates and
upgrade documentation required for updating
csi sidecar images.

Signed-off-by: Mudit Agarwal muagarwa@redhat.com
(cherry picked from commit c547b36)

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@agarwal-mudit
ceph: update csi sidecar images
a6b92a3 
This PR makes the changes in csi templates and
upgrade documentation required for updating
csi sidecar images.

Signed-off-by: Mudit Agarwal <muagarwa@redhat.com>
(cherry picked from commit c547b36)
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 29, 2020
@openshift-ci-robot
Copy link

@agarwal-mudit: This pull request references Bugzilla bug 1883398, which is invalid:

  • expected Bugzilla bug 1883398 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1883398: ceph: update csi sidecar images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leseb leseb requested a review from Madhu-1 September 29, 2020 09:25
Madhu-1
Madhu-1 approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agarwal-mudit once ocs-operator build is updated we can merge this one

travisn
travisn previously requested changes Sep 29, 2020
View reviewed changes
Copy link

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding until the CSI change is ready...

@Madhu-1 Madhu-1 requested a review from travisn October 1, 2020 06:24
@leseb leseb dismissed travisn’s stale review October 1, 2020 07:38

As per recent discussion, this patch is now required so merging.

leseb
leseb approved these changes Oct 1, 2020
View reviewed changes
Copy link

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per recent discussion, this patch is now required so merging.

@leseb leseb merged commit 3a780d2 into red-hat-storage:release-4.6 Oct 1, 2020
@openshift-ci-robot
Copy link

@agarwal-mudit: All pull requests linked via external trackers have merged:

Bugzilla bug 1883398 has been moved to the MODIFIED state.

In response to this:

Bug 1883398: ceph: update csi sidecar images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leseb leseb leseb approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@travisn travisn Awaiting requested review from travisn

Assignees
No one assigned
Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR.
Projects
None yet
Milestone
No milestone
5 participants
@agarwal-mudit @openshift-ci-robot @leseb @travisn @Madhu-1