Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1916585: ceph: osd pdb reconciler changes #152

Merged
merged 1 commit into from Jan 15, 2021
Merged

Bug 1916585: ceph: osd pdb reconciler changes #152

merged 1 commit into from Jan 15, 2021

Conversation

sp98
Copy link

@sp98 sp98 commented Dec 4, 2020

-creates a single PDB (max-unavailable=1) for all OSDs. This PDB allows one OSD to go down at a given time.
-When a drain is detected, blocking PDBs (max-unavailable=0) will be created for each failure domain that is not being drained and the main PDB (max-unavilable=1) will be deleted. This will allow all the OSDs in the currently drained failure domain to be removed while blocking the deletion of OSDs in other failure domains.
-Once the PGs are healthy again, the blocking PDBs will be deleted and the main PDB will be restored.
-Add PG healthcheck timeout
-Delete any legacy node drain pods and blocking OSD PDBs

Signed-off-by: Santosh Pillai sapillai@redhat.com
(cherry picked from commit 8602b9c)

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

-creates a single PDB (max-unavailable=1) for all OSDs.  This PDB allows one OSD to go down at a given time.
-When a drain is detected, blocking PDBs (max-unavailable=0) will be created for each failure domain that is not being drained and the main PDB (max-unavilable=1) will be deleted. This will allow all the OSDs in the currently drained failure domain to be removed while blocking the deletion  of OSDs in other failure domains.
-Once the PGs are healthy again, the blocking PDBs will be deleted and the main PDB will be restored.
-Add PG healthcheck timeout
-Delete any legacy node drain pods and blocking OSD PDBs

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
(cherry picked from commit 8602b9c)
@openshift-ci-robot
Copy link

@sp98: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

ceph: osd pdb reconciler changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp98 sp98 changed the title ceph: osd pdb reconciler changes BZ 1899743: ceph: osd pdb reconciler changes Dec 4, 2020
@openshift-ci-robot
Copy link

@sp98: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

BZ 1899743: ceph: osd pdb reconciler changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp98 sp98 changed the title BZ 1899743: ceph: osd pdb reconciler changes Bug 1899743: ceph: osd pdb reconciler changes Dec 4, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Dec 4, 2020
@openshift-ci-robot
Copy link

@sp98: This pull request references Bugzilla bug 1899743, which is invalid:

  • expected the bug to target the "4.6.z" release, but it targets "---" instead
  • expected dependent Bugzilla bug 1861104 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead
  • expected dependent Bugzilla bug 1861104 to target a release in 4.7.0, but it targets "OCS 4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1899743: ceph: osd pdb reconciler changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 4, 2020
@sp98 sp98 changed the title Bug 1899743: ceph: osd pdb reconciler changes [DNM] Bug 1899743: ceph: osd pdb reconciler changes Dec 4, 2020
@sp98 sp98 changed the title [DNM] Bug 1899743: ceph: osd pdb reconciler changes Bug 1915851: ceph: osd pdb reconciler changes Jan 15, 2021
@openshift-ci-robot
Copy link

@sp98: This pull request references Bugzilla bug 1915851, which is invalid:

  • expected the bug to target the "4.6.z" release, but it targets "OCS 4.7.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
  • expected dependent Bugzilla bug 1861104 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
  • expected dependent Bugzilla bug 1861104 to target a release in 4.7.0, but it targets "OCS 4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1915851: ceph: osd pdb reconciler changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp98 sp98 changed the title Bug 1915851: ceph: osd pdb reconciler changes Bug 1916585: ceph: osd pdb reconciler changes Jan 15, 2021
@openshift-ci-robot
Copy link

@sp98: This pull request references Bugzilla bug 1916585, which is invalid:

  • expected the bug to target the "4.6.z" release, but it targets "---" instead
  • expected dependent Bugzilla bug 1861104 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
  • expected dependent Bugzilla bug 1915851 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
  • expected dependent Bugzilla bug 1861104 to target a release in 4.7.0, but it targets "OCS 4.7.0" instead
  • expected dependent Bugzilla bug 1915851 to target a release in 4.7.0, but it targets "OCS 4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1916585: ceph: osd pdb reconciler changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travisn travisn merged commit 8c7ed58 into red-hat-storage:release-4.6 Jan 15, 2021
@openshift-ci-robot
Copy link

@sp98: All pull requests linked via external trackers have merged:

Bugzilla bug 1916585 has been moved to the MODIFIED state.

In response to this:

Bug 1916585: ceph: osd pdb reconciler changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting.
Projects
None yet
3 participants