Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1962109: ceph: pin volume replication to release-v0.1 branch #243

Merged
merged 1 commit into from May 26, 2021

Conversation

Madhu-1
Copy link
Member

@Madhu-1 Madhu-1 commented May 26, 2021

added volume replication operator release-v0.1 branch to the go.mod as we are doing enhancements to the volume replication CRDS. Once we have a release will change this to release-v0.1 branch.

Signed-off-by: Madhu Rajanna madhupr007@gmail.com
(cherry picked from commit 95d1bb9)
(cherry picked from commit b140578)

added volume replication operator release-v0.1
branch to the go.mod as we are doing enhancements to the
volume replicaiton CRDS. Once we have a release will
change this to release-v0.1 branch.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 95d1bb9)
(cherry picked from commit b140578)
@Madhu-1 Madhu-1 changed the title BUG 1962109: ceph: pin volume replication to release-v0.1 branch Bug1962109: ceph: pin volume replication to release-v0.1 branch May 26, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 26, 2021

@Madhu-1: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug1962109: ceph: pin volume replication to release-v0.1 branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Madhu-1
Copy link
Member Author

Madhu-1 commented May 26, 2021

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented May 26, 2021

@Madhu-1: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Madhu-1 Madhu-1 changed the title Bug1962109: ceph: pin volume replication to release-v0.1 branch Bug 1962109: ceph: pin volume replication to release-v0.1 branch May 26, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label May 26, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 26, 2021

@Madhu-1: This pull request references Bugzilla bug 1962109, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead
  • expected Bugzilla bug 1962109 to depend on a bug targeting a release in 4.9.0 and in one of the following states: MODIFIED, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1962109: ceph: pin volume replication to release-v0.1 branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 26, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 26, 2021

@Madhu-1: This pull request references Bugzilla bug 1962109, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead
  • expected Bugzilla bug 1962109 to depend on a bug targeting a release in 4.9.0 and in one of the following states: MODIFIED, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 1962109: ceph: pin volume replication to release-v0.1 branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented May 26, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iamniting, Madhu-1

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2021
@leseb
Copy link

leseb commented May 26, 2021

/test unit

@Madhu-1
Copy link
Member Author

Madhu-1 commented May 26, 2021

/bugzilla refresh

@Madhu-1
Copy link
Member Author

Madhu-1 commented May 26, 2021

/assign @leseb

@Madhu-1
Copy link
Member Author

Madhu-1 commented May 26, 2021

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented May 26, 2021

@Madhu-1: This pull request references Bugzilla bug 1962109, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "OCS 4.8.0" instead
  • expected Bugzilla bug 1962109 to depend on a bug targeting a release in 4.9.0 and in one of the following states: MODIFIED, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented May 26, 2021

@Madhu-1: This pull request references Bugzilla bug 1962109, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "OCS 4.8.0" instead
  • expected Bugzilla bug 1962109 to depend on a bug targeting a release in 4.9.0 and in one of the following states: MODIFIED, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leseb leseb merged commit 8680b99 into red-hat-storage:release-4.8 May 26, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 26, 2021

@Madhu-1: An error was encountered checking the state of a related pull request at csi-addons/volume-replication-operator#77 for bug 1962109 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Get "http://ghproxy/repos/csi-addons/volume-replication-operator/pulls/77": failed to get installation id for org csi-addons: the github app is not installed in organization csi-addons

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1962109: ceph: pin volume replication to release-v0.1 branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travisn
Copy link

travisn commented May 26, 2021

@Madhu-1 @leseb We could have picked this up in the next resync, right? Or was there a need for the individual backport?

@Madhu-1
Copy link
Member Author

Madhu-1 commented May 27, 2021

@Madhu-1 @leseb We could have picked this up in the next resync, right? Or was there a need for the individual backport?

@travisn apologies. I didn't know that we are resyncing to the 4.8 branch (in cephcsi we are not resyncing to 4.8 anymore we are doing PR backporting for BZ's). as we had a bug for this one I just created a manual PR.

@leseb
Copy link

leseb commented May 27, 2021

@Madhu-1 @leseb We could have picked this up in the next resync, right? Or was there a need for the individual backport?

I didn't want to slow down @Madhu-1 for whatever could be needed downstream and the PR was there so I didn't see the need to wait for a resync.

@travisn
Copy link

travisn commented May 27, 2021

That's fine, was just curious, the resync PR is so much easier IMO. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
4 participants