Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1821219: Allow toolbox script to skip watching mons #44

Merged
merged 1 commit into from Apr 22, 2020
Merged

Bug 1821219: Allow toolbox script to skip watching mons #44

merged 1 commit into from Apr 22, 2020

Conversation

travisn
Copy link

@travisn travisn commented Apr 22, 2020

Description of your changes:
The toolbox script is used for configuring the toolbox. If the mons are to fail over while the toolbox is running, the new list of mons needs to be updated. However, if run temporarily as a one-time job, the script only needs to initialize the ceph.conf and then exit.

Which issue is resolved by this Pull Request:
Related to BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1821219

Checklist:

  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.
  • Comments have been added or updated based on the standards set in CONTRIBUTING.md
  • Add the flag for skipping the CI if this PR does not require a build. See here for more details.

@travisn
ceph: allow toolbox script to skip watching mons
e576488 
The toolbox script is used for configuring the toolbox. If the
mons are to fail over while the toolbox is running, the new
list of mons needs to be updated. However, if run temporarily
as a one-time job, the script only needs to initialize the
ceph.conf and then exit.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit c024f01)
(cherry picked from commit 0d4af5d)
@openshift-ci-robot
Copy link

@travisn: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

ceph: allow toolbox script to skip watching mons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travisn travisn changed the title ceph: allow toolbox script to skip watching mons Allow toolbox script to skip watching mons Apr 22, 2020
@openshift-ci-robot
Copy link

@travisn: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Allow toolbox script to skip watching mons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travisn travisn changed the title Allow toolbox script to skip watching mons Bug: 1821219 Allow toolbox script to skip watching mons Apr 22, 2020
@travisn
Copy link
Author

travisn commented Apr 22, 2020

/bugzilla refresh

@travisn travisn merged commit 0b5cd6f into red-hat-storage:release-4.4 Apr 22, 2020
@travisn travisn deleted the toolbox-skip-updates branch April 22, 2020 17:03
@openshift-ci-robot
Copy link

@travisn: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug: 1821219 Allow toolbox script to skip watching mons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travisn travisn changed the title Bug: 1821219 Allow toolbox script to skip watching mons Bug 1821219: Allow toolbox script to skip watching mons Apr 22, 2020
@openshift-ci-robot
Copy link

@travisn: All pull requests linked via external trackers have merged: . Bugzilla bug 1821219 has been moved to the MODIFIED state.

In response to this:

Bug 1821219: Allow toolbox script to skip watching mons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@travisn @openshift-ci-robot