Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1852983: Require rgw pods to be running to create object users #81

Merged
merged 1 commit into from Jul 15, 2020

Conversation

travisn
Copy link

@travisn travisn commented Jul 13, 2020

Description of your changes:
The object user controller was intending to wait for rgw pods to be running before creating a user, however, after querying for the pods it didn't check if any pods were actually running. Creating the user before the object store was running causes the default rgw pools to potentially be created by ceph instead of allowing Rook to create the pools with the expected settings in the CR. Now we wait properly for the rgw to start before creating the object users.

Which issue is resolved by this Pull Request:
Resolves #https://bugzilla.redhat.com/show_bug.cgi?id=1852983

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

The object user controller was intending to wait for rgw pods to be running
before creating a user, however, after querying for the pods it didn't check
if any pods were actually running. Creating the user before the object
store was running causes the default rgw pools to potentially be created
by ceph instead of allowing Rook to create the pools with the expected
settings in the CR. Now we wait properly for the rgw to start before
creating the object users.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
@travisn travisn requested a review from leseb July 13, 2020 23:24
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jul 13, 2020
@openshift-ci-robot
Copy link

@travisn: This pull request references Bugzilla bug 1852983, which is invalid:

  • expected the bug to target the "4.4.z" release, but it targets "OCS 4.5.0" instead
  • expected Bugzilla bug 1852983 to depend on a bug targeting a release in 4.5.0, 4.5.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1852983: Require rgw pods to be running to create object users

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 13, 2020
@leseb leseb merged commit 877940c into red-hat-storage:release-4.4 Jul 15, 2020
@openshift-ci-robot
Copy link

@travisn: All pull requests linked via external trackers have merged: openshift/rook#81. Bugzilla bug 1852983 has been moved to the MODIFIED state.

In response to this:

Bug 1852983: Require rgw pods to be running to create object users

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travisn travisn deleted the wait-for-rgw-to-start branch July 15, 2020 13:40
@travisn travisn restored the wait-for-rgw-to-start branch July 15, 2020 15:28
@travisn travisn deleted the wait-for-rgw-to-start branch September 16, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting.
Projects
None yet
4 participants