Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1852983: Revert "ceph: require rgw pods to be running to create object users" #82

Merged

Conversation

obnoxxx
Copy link

@obnoxxx obnoxxx commented Jul 15, 2020

This reverts commit 6f257d8.

This was merged too early.
Branch is still locked down for 4.4.2
Will have to re-add after opening for 4.4.3.

Signed-off-by: Michael Adam obnox@redhat.com

Description of your changes:

Revert PR #81

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

This reverts commit 6f257d8.

This was merged too early.
Branch is still locked down for 4.4.2
Will have to re-add after opening for 4.4.3.

Signed-off-by: Michael Adam <obnox@redhat.com>
@openshift-ci-robot
Copy link

@obnoxxx: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Revert "ceph: require rgw pods to be running to create object users"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@obnoxxx obnoxxx changed the title Revert "ceph: require rgw pods to be running to create object users" Bug 1852983: Revert "ceph: require rgw pods to be running to create object users" Jul 15, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 15, 2020
@openshift-ci-robot
Copy link

@obnoxxx: This pull request references Bugzilla bug 1852983, which is invalid:

  • expected the bug to target the "4.4.z" release, but it targets "OCS 4.5.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected Bugzilla bug 1852983 to depend on a bug targeting a release in 4.5.0, 4.5.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1852983: Revert "ceph: require rgw pods to be running to create object users"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@obnoxxx
Copy link
Author

obnoxxx commented Jul 15, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@obnoxxx: This pull request references Bugzilla bug 1852983, which is invalid:

  • expected the bug to target the "4.4.z" release, but it targets "OCS 4.5.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected Bugzilla bug 1852983 to depend on a bug targeting a release in 4.5.0, 4.5.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@obnoxxx
Copy link
Author

obnoxxx commented Jul 15, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@obnoxxx: This pull request references Bugzilla bug 1852983, which is invalid:

  • expected the bug to target the "4.4.z" release, but it targets "OCS 4.5.0" instead
  • expected Bugzilla bug 1852983 to depend on a bug targeting a release in 4.5.0, 4.5.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travisn
Copy link

travisn commented Jul 15, 2020

@obnoxxx Thanks! You beat me to the revert, we had a misunderstanding about the merge.

@obnoxxx
Copy link
Author

obnoxxx commented Jul 16, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@obnoxxx: This pull request references Bugzilla bug 1852983, which is invalid:

  • expected the bug to target the "4.4.z" release, but it targets "---" instead
  • expected Bugzilla bug 1852983 to depend on a bug targeting a release in 4.5.0, 4.5.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@obnoxxx obnoxxx added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 16, 2020
@obnoxxx obnoxxx merged commit 3b52a4e into red-hat-storage:release-4.4 Jul 16, 2020
@openshift-ci-robot
Copy link

@obnoxxx: All pull requests linked via external trackers have merged: . Bugzilla bug 1852983 has been moved to the MODIFIED state.

In response to this:

Bug 1852983: Revert "ceph: require rgw pods to be running to create object users"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.
Projects
None yet
3 participants