-
Notifications
You must be signed in to change notification settings - Fork 186
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
OCM-7415 | feat: Ensure account roles have expected attached policies
Signed-off-by: marcolan018 <llan@redhat.com>
- Loading branch information
1 parent
da3615e
commit 6545ca1
Showing
8 changed files
with
422 additions
and
177 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| /* | ||
| Copyright (c) 2024 Red Hat, Inc. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package rolepolicybindings | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "strings" | ||
|
|
||
| "slices" | ||
|
|
||
| cmv1 "github.com/openshift-online/ocm-sdk-go/clustersmgmt/v1" | ||
|
|
||
| "github.com/openshift/rosa/pkg/aws" | ||
| ) | ||
|
|
||
| const ( | ||
| RolePolicyBindingFailedStatus = "failed" | ||
| ) | ||
|
|
||
| func CheckRolePolicyBindingStatus(bindings *cmv1.RolePolicyBindingList) error { | ||
| for _, binding := range bindings.Slice() { | ||
| if binding.Status().Value() == RolePolicyBindingFailedStatus { | ||
| return fmt.Errorf("Failed to get attach policies of role %s: %s", | ||
| binding.Name(), binding.Status().Description()) | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func CheckMissingRolePolicyBindings(desired, actual *cmv1.RolePolicyBindingList) (string, bool) { | ||
| output := "" | ||
| actualBindings := map[string][]string{} | ||
| for _, binding := range actual.Slice() { | ||
| roleBindings := []string{} | ||
| if binding != nil && binding.Policies() != nil { | ||
| for _, policy := range binding.Policies() { | ||
| roleBindings = append(roleBindings, policy.Arn()) | ||
| } | ||
| } | ||
| actualBindings[binding.Name()] = roleBindings | ||
| } | ||
| missingBindings := map[string][]string{} | ||
| for _, binding := range desired.Slice() { | ||
| if binding == nil { | ||
| continue | ||
| } | ||
| for _, policy := range binding.Policies() { | ||
| if !slices.Contains(actualBindings[binding.Name()], policy.Arn()) { | ||
| if missingBindings[binding.Name()] == nil { | ||
| missingBindings[binding.Name()] = []string{policy.Arn()} | ||
| } else { | ||
| missingBindings[binding.Name()] = append(missingBindings[binding.Name()], | ||
| policy.Arn()) | ||
| } | ||
| output = fmt.Sprintf(output+"Policy '%s' missed in role '%s'\n", policy.Arn(), binding.Name()) | ||
| } | ||
| } | ||
| } | ||
| if len(missingBindings) == 0 { | ||
| return output, false | ||
| } | ||
| output = output + "Run the following commands to attach the missing policies:\n" | ||
| for roleName, policies := range missingBindings { | ||
| output = output + fmt.Sprintf("rosa attach policy --role-name %s --policy-arns %s --mode auto\n", | ||
| roleName, strings.Join(policies[:], ",")) | ||
| } | ||
| return output, true | ||
| } | ||
|
|
||
| func TransformToRolePolicyDetails(bindingList *cmv1.RolePolicyBindingList) map[string][]aws.PolicyDetail { | ||
| rolePolicyDetails := map[string][]aws.PolicyDetail{} | ||
| for _, binding := range bindingList.Slice() { | ||
| policyDetails := []aws.PolicyDetail{} | ||
| if binding.Policies() != nil { | ||
| for _, policy := range binding.Policies() { | ||
| policyType := policy.Type() | ||
| if policyType != aws.Inline { | ||
| policyType = aws.Attached | ||
| } | ||
| policyDetails = append(policyDetails, aws.PolicyDetail{ | ||
| PolicyName: policy.Name(), | ||
| PolicyArn: policy.Arn(), | ||
| PolicyType: policyType, | ||
| }) | ||
| } | ||
| } | ||
| rolePolicyDetails[binding.Name()] = policyDetails | ||
| } | ||
| return rolePolicyDetails | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| /* | ||
| Copyright (c) 2024 Red Hat, Inc. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package rolepolicybindings | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "testing" | ||
|
|
||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
| cmv1 "github.com/openshift-online/ocm-sdk-go/clustersmgmt/v1" | ||
|
|
||
| "github.com/openshift/rosa/pkg/aws" | ||
| ) | ||
|
|
||
| func TestIdp(t *testing.T) { | ||
| RegisterFailHandler(Fail) | ||
| RunSpecs(t, "RolePolicyBinding") | ||
| } | ||
|
|
||
| var ( | ||
| roleName1 = "sample-role-1" | ||
| roleName2 = "sample-role-2" | ||
| policyArn1 = "sample-policy-arn-1" | ||
| policyName1 = "sample-policy-name-1" | ||
| policyArn2 = "sample-policy-arn-2" | ||
| policyName2 = "sample-policy-name-2" | ||
| errDesc = "sample-err-description" | ||
| failedBinding = cmv1.NewRolePolicyBinding(). | ||
| Name(roleName1). | ||
| Status(cmv1.NewRolePolicyBindingStatus(). | ||
| Value(RolePolicyBindingFailedStatus). | ||
| Description(errDesc)) | ||
| policyBuilder1 = cmv1.NewRolePolicy().Arn(policyArn1).Name(policyName1).Type(aws.Inline) | ||
| policyBuilder2 = cmv1.NewRolePolicy().Arn(policyArn2).Name(policyName2).Type("customer") | ||
| binding1 = cmv1.NewRolePolicyBinding(). | ||
| Name(roleName1). | ||
| Policies(policyBuilder1) | ||
| actualBinding2 = cmv1.NewRolePolicyBinding(). | ||
| Name(roleName2). | ||
| Policies(policyBuilder2) | ||
| desiredBinding2 = cmv1.NewRolePolicyBinding(). | ||
| Name(roleName2). | ||
| Policies(policyBuilder1, policyBuilder2) | ||
| ) | ||
|
|
||
| var _ = Describe("Policy Service", func() { | ||
| Context("Attach Policy", Ordered, func() { | ||
| It("Test ValidateRolePolicyBindings", func() { | ||
| bindingList, err := cmv1.NewRolePolicyBindingList().Items(failedBinding).Build() | ||
| Expect(err).ShouldNot(HaveOccurred()) | ||
| err = CheckRolePolicyBindingStatus(bindingList) | ||
| Expect(err).Should(HaveOccurred()) | ||
| Expect(err.Error()).To(Equal(fmt.Sprintf("Failed to get attach policies of role %s: %s", | ||
| roleName1, errDesc))) | ||
| }) | ||
| It("Test CheckMissingRolePolicyBindings -- No missing rolepolicy binding", func() { | ||
| desiredBindings, err := cmv1.NewRolePolicyBindingList().Items(binding1).Build() | ||
| Expect(err).ShouldNot(HaveOccurred()) | ||
| actualBindings, err := cmv1.NewRolePolicyBindingList().Items(binding1).Build() | ||
| Expect(err).ShouldNot(HaveOccurred()) | ||
| output, isBindingMissed := CheckMissingRolePolicyBindings(desiredBindings, actualBindings) | ||
| Expect(isBindingMissed).To(Equal(false)) | ||
| Expect(output).To(Equal("")) | ||
| }) | ||
| It("Test CheckMissingRolePolicyBindings -- Find missing rolepolicy binding", func() { | ||
| desiredBindings, err := cmv1.NewRolePolicyBindingList().Items(binding1, desiredBinding2).Build() | ||
| Expect(err).ShouldNot(HaveOccurred()) | ||
| actualBindings, err := cmv1.NewRolePolicyBindingList().Items(binding1, actualBinding2).Build() | ||
| Expect(err).ShouldNot(HaveOccurred()) | ||
| output, isBindingMissed := CheckMissingRolePolicyBindings(desiredBindings, actualBindings) | ||
| Expect(isBindingMissed).To(Equal(true)) | ||
| Expect(output).To(Equal(fmt.Sprintf("Policy '%s' missed in role '%s'\n"+ | ||
| "Run the following commands to attach the missing policies:\n"+ | ||
| "rosa attach policy --role-name %s --policy-arns %s --mode auto\n", | ||
| policyArn1, roleName2, roleName2, policyArn1))) | ||
| }) | ||
| It("Test TransformToRolePolicyDetails", func() { | ||
| bindingList, err := cmv1.NewRolePolicyBindingList().Items(binding1, actualBinding2).Build() | ||
| Expect(err).ShouldNot(HaveOccurred()) | ||
| rolePoliyDetails := TransformToRolePolicyDetails(bindingList) | ||
| Expect(rolePoliyDetails[roleName1]).NotTo(BeNil()) | ||
| Expect(rolePoliyDetails[roleName1]).To(HaveLen(1)) | ||
| Expect(rolePoliyDetails[roleName1][0]).To(BeEquivalentTo(aws.PolicyDetail{ | ||
| PolicyName: policyName1, | ||
| PolicyArn: policyArn1, | ||
| PolicyType: aws.Inline, | ||
| })) | ||
| Expect(rolePoliyDetails[roleName2]).NotTo(BeNil()) | ||
| Expect(rolePoliyDetails[roleName2]).To(HaveLen(1)) | ||
| Expect(rolePoliyDetails[roleName2][0]).To(BeEquivalentTo(aws.PolicyDetail{ | ||
| PolicyName: policyName2, | ||
| PolicyArn: policyArn2, | ||
| PolicyType: aws.Attached, | ||
| })) | ||
| }) | ||
| }) | ||
| }) |
Oops, something went wrong.