Skip to content

Commit

Permalink
OCM-6391 | fix: Change default value for disable region dep. flag
Browse files Browse the repository at this point in the history
  • Loading branch information
hunterkepley committed May 1, 2024
1 parent cd2d1ab commit a511dea
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions cmd/create/cluster/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -3218,7 +3218,7 @@ func run(cmd *cobra.Command, _ []string) {
" print for cluster describe called inside cluster create, but there is a use for a lone describe."
var disableRegionDeprecation bool
clusterdescribe.Cmd.LocalFlags().BoolVar(&disableRegionDeprecation, arguments.DisableRegionDeprecationFlagName,
true, disableUsage)
false, disableUsage)
clusterdescribe.Cmd.Run(clusterdescribe.Cmd, []string{cluster.ID()})
disableRegionDeprecation = false // No longer disable

Expand All @@ -3229,13 +3229,13 @@ func run(cmd *cobra.Command, _ []string) {
}
disableRegionDeprecation = true // disable again
operatorroles.Cmd.LocalFlags().BoolVar(&disableRegionDeprecation, arguments.DisableRegionDeprecationFlagName,
true, disableUsage)
false, disableUsage)
operatorroles.Cmd.Run(operatorroles.Cmd, []string{clusterName, mode, permissionsBoundary})
if !output.HasFlag() || r.Reporter.IsTerminal() {
r.Reporter.Infof("Preparing to create OIDC Provider.")
}
oidcprovider.Cmd.LocalFlags().BoolVar(&disableRegionDeprecation, arguments.DisableRegionDeprecationFlagName,
true, disableUsage)
false, disableUsage)
oidcprovider.Cmd.Run(oidcprovider.Cmd, []string{clusterName, mode, ""})
disableRegionDeprecation = false // No longer disable
} else {
Expand Down Expand Up @@ -3272,7 +3272,11 @@ func run(cmd *cobra.Command, _ []string) {
}

if args.watch {
disableRegionDeprecation = true // Disable region deprecation
clusterdescribe.Cmd.LocalFlags().BoolVar(&disableRegionDeprecation, arguments.DisableRegionDeprecationFlagName,
false, disableUsage)
installLogs.Cmd.Run(installLogs.Cmd, []string{clusterName})
disableRegionDeprecation = false // No longer disable
} else if !output.HasFlag() || r.Reporter.IsTerminal() {
r.Reporter.Infof(
"To determine when your cluster is Ready, run 'rosa describe cluster -c %s'.",
Expand Down

0 comments on commit a511dea

Please sign in to comment.