Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "OCM-4883 | fix: fetch passed arn in all roles" #1641

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Revert "OCM-4883 | fix: fetch passed arn in all roles" #1641

merged 1 commit into from
Dec 4, 2023

Conversation

oriAdler
Copy link
Contributor

@oriAdler oriAdler commented Dec 4, 2023

This reverts commit 523ee07.

@oriAdler
Copy link
Contributor Author

oriAdler commented Dec 4, 2023

Reverting PR due to this discussion https://redhat-internal.slack.com/archives/C03TU14HLB0/p1701697274000609?thread_ts=1701669220.349789&cid=C03TU14HLB0

@openshift-ci openshift-ci bot requested review from pvasant and zgalor December 4, 2023 13:49
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

@oriAdler: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chenz4027
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenz4027, oriAdler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b0d23be into openshift:master Dec 4, 2023
6 checks passed
@oriAdler oriAdler deleted the OCM-4883 branch March 20, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvasant pvasant Awaiting requested review from pvasant

@zgalor zgalor Awaiting requested review from zgalor

Assignees

@chenz4027 chenz4027

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oriAdler @chenz4027