Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-5621 | feat: Add codecov to CI pipeline for ROSA #1659

Conversation

robpblake
Copy link
Contributor

@robpblake robpblake commented Dec 14, 2023

This PR is the first step for adding CodeCov coverage checking to the ROSA CI pipeline. In this PR I'm simply introducing a Makefile target and a bash script to upload results to CodeCov. The bash script has been copied from other projects uploading to CodeCov within the openshift org, and then slightly adapated to match our project.

Next steps will be to update our prow configuration to run this on each PR and then on merges to master so that we have a record of our coverage statistics over time.

Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

@robpblake: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@davidleerh
Copy link
Contributor

Aside from the move of the command to create the temporary coverage file from within the shell script to the makefile,
confirming script is identical to coverage upload scripts used in other openshift projects:
ex - https://github.com/openshift/hive/blob/e5f809fca22b9629c325c2ef88d384764645bf89/hack/codecov.sh#L8

@davidleerh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2023
@robpblake
Copy link
Contributor Author

@davidleerh I wanted us to be able to run coverage checks independently of codecov, so I kept that part in the Makefile as a separate target 👍

@gdbranco
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidleerh, gdbranco, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 3c3dfe2 into openshift:master Dec 15, 2023
6 checks passed
@robpblake robpblake deleted the ocm-5261-add-codecov-to-rosa-ci branch January 26, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants