OCM-4966 | feat: Add keyring support for configuration

[tylercreller]

OCM-4966

• Added keyring support for configuration storage via OCM_KEYRING
  • Added README docs
  • Added keyring support for config saves, loads, removal
  • Removes configuration from keyring on logout
• Added basic login tests
• Added keyring tests for config

Other

• Fixed support for client-id / client-secret login
• Added support for preferred_username claim, required for organizational service accounts

[openshift-ci-robot]

@tylercreller: This pull request references OCM-4966 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

• Added keyring support for configuration storage via RH_KEYRING
  • Added README docs
  • Added support for config saves, loads, removal
  • Removes configuration from keyring on logout
  • Added ocm config get keyrings to view available keyrings on the host OS
• Added basic login tests
• Added keyring tests for config

Other

• Fixed support for client-id / client-secret login
• Added support for preferred_username claim, required for organizational service accounts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@tylercreller: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

• Added keyring support for configuration storage via RH_KEYRING
  • Added README docs
  • Added support for config saves, loads, removal
  • Removes configuration from keyring on logout
  • Added ocm config get keyrings to view available keyrings on the host OS
• Added basic login tests
• Added keyring tests for config

Other

• Fixed support for client-id / client-secret login
• Added support for preferred_username claim, required for organizational service accounts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tylercreller]

/jira refresh

[openshift-ci-robot]

@tylercreller: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tylercreller]

/jira refresh

[openshift-ci-robot]

@tylercreller: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

Attention: Patch coverage is 57.83133% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 21.19%. Comparing base (cd5638f) to head (02ccd5c).
Report is 6 commits behind head on master.

Files	Patch %	Lines
cmd/login/cmd.go	30.00%	27 Missing and 1 partial ⚠️
pkg/config/config.go	80.55%	6 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1825      +/-   ##
==========================================
+ Coverage   21.04%   21.19%   +0.15%     
==========================================
  Files         104      113       +9     
  Lines       17688    18831    +1143     
==========================================
+ Hits         3722     3992     +270     
- Misses      13688    14530     +842     
- Partials      278      309      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ciaranRoche]

/retest

[ciaranRoche]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche, tylercreller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ciaranRoche]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@tylercreller: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.