Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCM-6314 | ci: Refactor day1 creation function for test #1861

Merged
merged 1 commit into from Apr 9, 2024
Merged

OCM-6314 | ci: Refactor day1 creation function for test #1861

merged 1 commit into from Apr 9, 2024

Conversation

xueli181114
Copy link
Contributor

This PR is used to track the day1 function refactor for automation test

@openshift-ci openshift-ci bot requested review from radtriste and yasun1 March 19, 2024 10:19
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2024
@xueli181114 xueli181114 marked this pull request as draft March 19, 2024 10:20
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 19, 2024
yasun1
yasun1 reviewed Mar 20, 2024
View reviewed changes
tests/ci/config/config.go Outdated Show resolved Hide resolved
tests/ci/config/config.go Outdated Show resolved Hide resolved
tests/ci/config/config.go Outdated Show resolved Hide resolved
tests/ci/config/config.go Outdated Show resolved Hide resolved
tests/ci/config/config.go Show resolved Hide resolved
tests/ci/profiles/rosa-hcp.yaml Outdated Show resolved Hide resolved
tests/ci/profiles/rosa-hcp.yaml Outdated Show resolved Hide resolved
tests/e2e/dummy_test.go Outdated Show resolved Hide resolved
tests/utils/profilehandler/interface.go Show resolved Hide resolved
tests/utils/profilehandler/interface.go Outdated Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2024
@xueli181114 xueli181114 force-pushed the master branch 2 times, most recently from ef230c1 to 2ad0ae1 Compare March 21, 2024 08:19
@xueli181114 xueli181114 force-pushed the master branch 2 times, most recently from 96fd527 to fae78fe Compare April 2, 2024 12:41
@xueli181114 xueli181114 changed the title Draft: OCM-6314 Refactor day1 creation function for test OCM-6314 Refactor day1 creation function for test Apr 2, 2024
@xueli181114 xueli181114 marked this pull request as ready for review April 2, 2024 12:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2024
@xueli181114 xueli181114 force-pushed the master branch 2 times, most recently from 7aa5712 to c1ff6d3 Compare April 2, 2024 13:59
@xueli181114 xueli181114 changed the title OCM-6314 Refactor day1 creation function for test OCM-6314 | ci: Refactor day1 creation function for test Apr 3, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 3, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.69%. Comparing base (b3f87d7) to head (e7a5023).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1861   +/-   ##
=======================================
  Coverage   21.69%   21.69%           
=======================================
  Files         118      118           
  Lines       19782    19782           
=======================================
  Hits         4292     4292           
  Misses      15165    15165           
  Partials      325      325

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yingzhanredhat
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2024
ciaranRoche
ciaranRoche reviewed Apr 8, 2024
View reviewed changes
Copy link
Member

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot of helpers and such do we plan to cover these with Unit Tests?

Overall looks good to me, left some nitpicks inline.

tests/utils/exec/rosacli/ocm_resource_service.go Outdated Show resolved Hide resolved
tests/utils/profilehandler/data_preparation.go Outdated Show resolved Hide resolved
tests/utils/profilehandler/data_preparation.go Outdated Show resolved Hide resolved
tests/utils/profilehandler/data_preparation.go Outdated Show resolved Hide resolved
tests/utils/profilehandler/interface.go Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2024
@xueli181114
Copy link
Contributor Author

@ciaranRoche Comments updated and resolved. Do you mind to review again?

radtriste
radtriste reviewed Apr 8, 2024
View reviewed changes
Copy link
Contributor

@radtriste radtriste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments. otherwise lgtm

tests/utils/profilehandler/profile_handler.go Show resolved Hide resolved
tests/utils/exec/rosacli/cluster_service.go Outdated Show resolved Hide resolved
@xueli181114 xueli181114 force-pushed the master branch 3 times, most recently from f1ea8a8 to 483c117 Compare April 9, 2024 06:52
@xueli181114
OCM-6314 | ci: Refactor day1 creation function for test
e7a5023 
Fix comments

Fix comment

Remove the redunant func

OCM-6314 | ci: Refactor day1 creation function for test

Fix name prefix cannot be set issue
@radtriste
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 9, 2024

@xueli181114: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ciaranRoche
Copy link
Member

/lgtm

@ciaranRoche
Copy link
Member

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche, radtriste, xueli181114, yingzhanredhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche, radtriste, xueli181114, yingzhanredhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit baffdc8 into openshift:master Apr 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciaranRoche ciaranRoche ciaranRoche left review comments

@yasun1 yasun1 yasun1 left review comments

@radtriste radtriste radtriste approved these changes

@davidleerh davidleerh Awaiting requested review from davidleerh

@yingzhanredhat yingzhanredhat Awaiting requested review from yingzhanredhat

Assignees

@ciaranRoche ciaranRoche

@radtriste radtriste

@yingzhanredhat yingzhanredhat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xueli181114 @yingzhanredhat @radtriste @ciaranRoche @yasun1 @openshift-merge-robot