Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6079 | feat: support cluster admin day-1 creation for HCP cluster #1863

Merged
merged 1 commit into from Apr 10, 2024

Conversation

marcolan018
Copy link
Contributor

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 21.76%. Comparing base (8e6cd33) to head (0708d24).
Report is 16 commits behind head on master.

Files Patch % Lines
cmd/create/cluster/cmd.go 0.00% 39 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1863      +/-   ##
==========================================
+ Coverage   21.68%   21.76%   +0.07%     
==========================================
  Files         118      118              
  Lines       19779    19774       -5     
==========================================
+ Hits         4289     4303      +14     
+ Misses      15165    15145      -20     
- Partials      325      326       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcolan018
Copy link
Contributor Author

/retest

3 similar comments
@marcolan018
Copy link
Contributor Author

/retest

@marcolan018
Copy link
Contributor Author

/retest

@marcolan018
Copy link
Contributor Author

/retest

@robpblake
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2024
@robpblake
Copy link
Contributor

Added /hold pending discussion around user-experience of cluster admin commands.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2024
@marcolan018
Copy link
Contributor Author

the custom username feature is postponed and I can continue the hcp support work
@robpblake can you help to review this pr again? Thanks

@robpblake
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2024
cmd/create/cluster/cmd.go Outdated Show resolved Hide resolved
Copy link
Contributor

openshift-ci bot commented Apr 9, 2024

@marcolan018: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@robpblake robpblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marcolan018, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 57e45ab into openshift:master Apr 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants