Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6822 | fix: add validations for external auth #1865

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

chenz4027
Copy link
Contributor

Signed-off-by: Maggie Chen <magchen@redhat.com>
@openshift-ci openshift-ci bot requested review from gdbranco and pvasant March 20, 2024 19:04
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 21.05%. Comparing base (897b1c3) to head (84e46fd).
Report is 6 commits behind head on master.

Files Patch % Lines
cmd/list/externalauthprovider/cmd.go 50.00% 1 Missing and 1 partial ⚠️
cmd/describe/externalauthprovider/cmd.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1865      +/-   ##
==========================================
+ Coverage   20.92%   21.05%   +0.12%     
==========================================
  Files         103      104       +1     
  Lines       17343    17690     +347     
==========================================
+ Hits         3629     3724      +95     
- Misses      13439    13688     +249     
- Partials      275      278       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philipwu08
Copy link
Contributor

lgtm

Copy link
Contributor

@robpblake robpblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2024
Copy link
Contributor

openshift-ci bot commented Mar 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenz4027, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2024
Copy link
Contributor

openshift-ci bot commented Mar 22, 2024

@chenz4027: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 00145ef into openshift:master Mar 22, 2024
9 checks passed
@chenz4027 chenz4027 deleted the OCM-6822 branch May 9, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants