Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6879 | fix: allow user specify cluster-admin as admin username in day-1 #1869

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

marcolan018
Copy link
Contributor

Signed-off-by: marcolan018 llan@redhat.com

Signed-off-by: marcolan018 <llan@redhat.com>
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 31.57895% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 21.19%. Comparing base (053e5e8) to head (a69e789).
Report is 10 commits behind head on master.

Files Patch % Lines
cmd/create/idp/htpasswd.go 33.33% 12 Missing ⚠️
cmd/create/cluster/cmd.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1869      +/-   ##
==========================================
+ Coverage   20.63%   21.19%   +0.56%     
==========================================
  Files         102      104       +2     
  Lines       17270    17724     +454     
==========================================
+ Hits         3563     3757     +194     
- Misses      13439    13684     +245     
- Partials      268      283      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@robpblake robpblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2024
Copy link
Contributor

openshift-ci bot commented Mar 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marcolan018, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2024
Copy link
Contributor

openshift-ci bot commented Mar 22, 2024

@marcolan018: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 709d754 into openshift:master Mar 22, 2024
9 checks passed
@marcolan018 marcolan018 deleted the ocm-6879 branch March 22, 2024 16:42
gdbranco pushed a commit that referenced this pull request Apr 1, 2024
OCM-6879 | fix: allow user specify `cluster-admin` as admin username in day-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants