Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6883 | fix: rosa describe admin can list the admin with custom name #1873

Merged
merged 1 commit into from Mar 26, 2024

Conversation

marcolan018
Copy link
Contributor

@marcolan018 marcolan018 commented Mar 26, 2024

https://issues.redhat.com/browse/OCM-6883

Signed-off-by: marcolan018 llan@redhat.com

In this PR, rosa describe admin will list out all users in cluster-admins group.
For the commands rosa create admin and rosa delete admin, they continue to only handle the cluster-admin user in cluster-admins group. Update help messages for those commands to make this more clear

@marcolan018
Copy link
Contributor Author

/retest

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.49%. Comparing base (94a5865) to head (d87f940).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1873      +/-   ##
==========================================
+ Coverage   21.47%   21.49%   +0.01%     
==========================================
  Files         113      113              
  Lines       18664    18668       +4     
==========================================
+ Hits         4009     4013       +4     
  Misses      14349    14349              
  Partials      306      306              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche, marcolan018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

@marcolan018: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 225cd4f into openshift:master Mar 26, 2024
9 checks passed
@marcolan018 marcolan018 deleted the ocm-6883 branch March 26, 2024 12:41
gdbranco pushed a commit that referenced this pull request Mar 26, 2024
OCM-6883 | fix: rosa describe admin can list the admin with custom name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants