Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-5549 | feat: Disable listing services while using FedRAMP login #1874

Merged
merged 1 commit into from Mar 26, 2024

Conversation

hunterkepley
Copy link
Contributor

https://issues.redhat.com/browse/OCM-5549

This MR makes it so when you are logged into FedRAMP envs, you cannot list managed services. Prevents a strange, and confusing error to the user.

@marcolan018
Copy link
Contributor

@hunterkepley
how about other command such as rosa describe service?

Copy link
Member

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the same check for create/describe/delete service commands also 🙏

@hunterkepley
Copy link
Contributor Author

@ciaranRoche Create is covered from the last MR: #1851
Will update describe and delete though 👍

@marcolan018
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.53%. Comparing base (225cd4f) to head (36047ff).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1874      +/-   ##
==========================================
+ Coverage   21.49%   21.53%   +0.04%     
==========================================
  Files         113      113              
  Lines       18667    18673       +6     
==========================================
+ Hits         4012     4021       +9     
+ Misses      14349    14346       -3     
  Partials      306      306              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oriAdler
Copy link
Contributor

@hunterkepley should we add the check for the create service command as well?

@hunterkepley
Copy link
Contributor Author

@hunterkepley should we add the check for the create service command as well?

@oriAdler https://github.com/openshift/rosa/pull/1851/files -- was done in this MR 👍

Copy link
Contributor

@robpblake robpblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's align with our previous implementation: #1851

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@hunterkepley hunterkepley reopened this Mar 26, 2024
@hunterkepley
Copy link
Contributor Author

Not sure why it closed 😆 but made the change @robpblake

Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

@hunterkepley: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@robpblake robpblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hunterkepley, marcolan018, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 43933c7 into openshift:master Mar 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants