New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-5549 | feat: Disable listing services while using FedRAMP login #1874
Conversation
@hunterkepley |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the same check for create/describe/delete service commands also 🙏
@ciaranRoche Create is covered from the last MR: #1851 |
/lgtm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1874 +/- ##
==========================================
+ Coverage 21.49% 21.53% +0.04%
==========================================
Files 113 113
Lines 18667 18673 +6
==========================================
+ Hits 4012 4021 +9
+ Misses 14349 14346 -3
Partials 306 306 ☔ View full report in Codecov by Sentry. |
@hunterkepley should we add the check for the create service command as well? |
@oriAdler https://github.com/openshift/rosa/pull/1851/files -- was done in this MR 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's align with our previous implementation: #1851
Not sure why it closed 😆 but made the change @robpblake |
@hunterkepley: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hunterkepley, marcolan018, robpblake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/OCM-5549
This MR makes it so when you are logged into FedRAMP envs, you cannot list managed services. Prevents a strange, and confusing error to the user.