Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6822 | fix: use cluster name in error message #1875

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

chenz4027
Copy link
Contributor

@chenz4027 chenz4027 commented Mar 26, 2024

https://issues.redhat.com/browse/OCM-6822

Error now shows the cluster name instead of cluster id:

E: failed to create an external authentication provider for cluster 'magchen-hcp': external_auth.issuer.audiences must contain at least one audience

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 21.86%. Comparing base (92a2ed3) to head (43ada2f).
Report is 2 commits behind head on master.

Files Patch % Lines
pkg/externalauthprovider/flags.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1875      +/-   ##
==========================================
+ Coverage   21.81%   21.86%   +0.04%     
==========================================
  Files         117      117              
  Lines       18920    18932      +12     
==========================================
+ Hits         4128     4139      +11     
- Misses      14481    14482       +1     
  Partials      311      311              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcolan018
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
Signed-off-by: Maggie Chen <magchen@redhat.com>

change to clusterKey

Signed-off-by: Maggie Chen <magchen@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@chenz4027 chenz4027 requested a review from gdbranco March 26, 2024 20:30
@gdbranco
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenz4027, gdbranco, marcolan018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

@chenz4027: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4a3534f into openshift:master Mar 26, 2024
9 checks passed
@chenz4027 chenz4027 deleted the OCM-6822-fix branch May 9, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants