OCM-6697 | fix: upgrade role error should print extra info when invoke from upgrade cluster

[mikeshng]

In PR, some of the error handlings were removed. I've gone through each one of them and brought back the one that should be present: upgrade role error handling when invoke from upgrade cluster.

Jira ref

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 20.75%. Comparing base (9a635e0) to head (eed055a).
Report is 30 commits behind head on master.

Files	Patch %	Lines
cmd/upgrade/roles/cmd.go	0.00%	16 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1878      +/-   ##
==========================================
- Coverage   21.82%   20.75%   -1.08%     
==========================================
  Files         117      118       +1     
  Lines       18921    20853    +1932     
==========================================
+ Hits         4129     4327     +198     
- Misses      14481    16147    +1666     
- Partials      311      379      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chenz4027]

/lgtm
I kinda wanna propose adding unit test for printClusterUpgradeInfo, but it might be tough for reporter. Up to you Mike.

[oriAdler]

LGTM, can you please attach a sample output to the PR? just to get a sense of how the info message looks to the user?

[mikeshng]

/hold

[mikeshng]

LGTM, can you please attach a sample output to the PR? just to get a sense of how the info message looks to the user?

I: Account/Operator Role policies are not valid with upgrade version 4.15. Run the following command(s) to upgrade the roles:
        rosa upgrade roles -c redacted_cluster_id_string_here --cluster-version=4.15 --mode=auto

, then run the upgrade command again:
	rosa upgrade cluster -c redacted_cluster_id_string_here

@oriAdler PTAL thanks

[mikeshng]

/unhold

[chenz4027]

/lgtm

[robpblake]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenz4027, mikeshng, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [robpblake]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@mikeshng: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.