Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCM-6375 | fix: error out if cluster is enabled with external auth #1879

Merged
merged 1 commit into from Mar 28, 2024
Merged

OCM-6375 | fix: error out if cluster is enabled with external auth #1879

merged 1 commit into from Mar 28, 2024

Conversation

chenz4027
Copy link
Contributor

@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 21.81%. Comparing base (4a3534f) to head (ffcbfc3).

Files Patch % Lines
cmd/create/admin/cmd.go 0.00% 5 Missing ⚠️
cmd/create/idp/cmd.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1879      +/-   ##
==========================================
- Coverage   21.82%   21.81%   -0.01%     
==========================================
  Files         117      117              
  Lines       18921    18929       +8     
==========================================
  Hits         4129     4129              
- Misses      14481    14489       +8     
  Partials      311      311

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreadecorte
Copy link
Contributor

https://github.com/openshift/rosa/blob/master/cmd/describe/admin/cmd.go probably also this one should be checked

mikeshng
mikeshng reviewed Mar 27, 2024
View reviewed changes
cmd/dlt/idp/cmd.go
@@ -58,8 +58,13 @@ func run(_ *cobra.Command, argv []string) {
idpName := argv[0]

clusterKey := r.GetClusterKey()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super-nit: since you probably have to address Andrea's comment so you might as well undo this change unless it's lint related.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed as sugessted

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@chenz4027
OCM-6375 | fix: error out if cluster is enabled with external auth
ffcbfc3 
Signed-off-by: Maggie Chen <magchen@redhat.com>

fix lint

Signed-off-by: Maggie Chen <magchen@redhat.com>

add describe case

Signed-off-by: Maggie Chen <magchen@redhat.com>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

@chenz4027: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chenz4027 chenz4027 requested a review from mikeshng March 27, 2024 17:49
@chenz4027
Copy link
Contributor Author

@andreadecorte Added the validation for describe

mikeshng
mikeshng approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
robpblake
robpblake approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@robpblake robpblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenz4027, mikeshng, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 61aed4f into openshift:master Mar 28, 2024
9 checks passed
@chenz4027 chenz4027 deleted the OCM-6375 branch May 9, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robpblake robpblake robpblake approved these changes

@mikeshng mikeshng mikeshng approved these changes

@ciaranRoche ciaranRoche Awaiting requested review from ciaranRoche

@willkutler willkutler Awaiting requested review from willkutler

Assignees

@robpblake robpblake

@mikeshng mikeshng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chenz4027 @andreadecorte @robpblake @mikeshng