OCM-6302 | ci: Prow job update to check PR author in commit check #1881
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1881 +/- ##
==========================================
- Coverage 21.82% 21.81% -0.01%
==========================================
Files 117 117
Lines 18921 18929 +8
==========================================
Hits 4129 4129
- Misses 14481 14489 +8
Partials 311 311 ☔ View full report in Codecov by Sentry. |
hunterkepley
force-pushed
the
ocm-6302-2
branch
from
342a7f7
to
f00dc0b
Compare
hack/commit-msg-verify.sh
Outdated
| if ! echo "$message" | grep -qE "^[A-Z]+-[0-9]+ \| (feat|fix|docs|style|refactor|test|chore|build|ci|perf): .*$"; then | ||
| echo "Invalid commit message format. Expected format: JIRA_TICKET | TYPE: MESSAGE" | ||
| echo "Where:" | ||
| echo " JIRA_TICKET is jira ticket ID (for example OCM-xxx)" |
There was a problem hiding this comment.
Just a question from my end on contributing.
If people outside the RH org wants to contribute to this open source project, does that imply that we supply the contributors with the JIRA number via "github issues" prior to allowing them to commit?
There was a problem hiding this comment.
As discussed in our call, im not too sure, but this logic was already in place, so the same system applies 😃
There was a problem hiding this comment.
@davidleerh It's a good discussion point.
Our release notes for rosa as a product are generated from Jira issues, so I think a practice could be that if/when we had a community contribution, we could create a Jira on their behalf?
Wanna bring it up at office hours?
There was a problem hiding this comment.
Let's discuss then, I think creating a ticket on their behalf is a great idea especially since the release notes are generated via jira issues
There was a problem hiding this comment.
@hunterkepley Can you remove CodeCov bot as a PR author. It shouldn't have commit permissions on our repo.
hunterkepley
force-pushed
the
ocm-6302-2
branch
from
f00dc0b
to
2ea6f3b
Compare
hunterkepley
force-pushed
the
ocm-6302-2
branch
from
7677849
to
374c1d5
Compare
|
@hunterkepley: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hunterkepley, robpblake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
https://issues.redhat.com/browse/OCM-6302
Updates the hack script, ran by prow, which checks PR commit msgs to also check PR author