Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert ocm-6883 #1883

Merged
merged 2 commits into from Mar 28, 2024
Merged

Revert ocm-6883 #1883

merged 2 commits into from Mar 28, 2024

Conversation

gdbranco
Copy link
Contributor

@gdbranco gdbranco commented Mar 28, 2024 •
edited by openshift-ci bot

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.81%. Comparing base (0c0f1c3) to head (93d752f).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1883   +/-   ##
=======================================
  Coverage   21.81%   21.81%           
=======================================
  Files         117      117           
  Lines       18929    18929           
=======================================
  Hits         4129     4129           
  Misses      14489    14489           
  Partials      311      311

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcolan018
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
@ciaranRoche
Copy link
Member

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

@gdbranco: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche, gdbranco, marcolan018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ciaranRoche,gdbranco]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d88d6b1 into openshift:master Mar 28, 2024
9 checks passed
gdbranco pushed a commit that referenced this pull request Mar 28, 2024
@openshift-merge-bot @gdbranco
Merge pull request #1883 from gdbranco/chore/revert-ocm-6883
eb8d019 
Revert ocm-6883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciaranRoche ciaranRoche Awaiting requested review from ciaranRoche

@thomasmckay thomasmckay Awaiting requested review from thomasmckay

Assignees

@marcolan018 marcolan018

@ciaranRoche ciaranRoche

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gdbranco @marcolan018 @ciaranRoche