Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6926 | fix: Added back the condition to check for empty env flag #1893

Merged

Conversation

tirthct
Copy link
Contributor

@tirthct tirthct commented Apr 1, 2024

Changed

  • Added back the condition to check for empty env flag

Tested

  • FedRAMP login flow should work as expected : tested

@openshift-ci openshift-ci bot requested review from den-rgb and gdbranco April 1, 2024 17:36
Copy link
Contributor

openshift-ci bot commented Apr 1, 2024

@tirthct: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.82%. Comparing base (f107b6f) to head (4ee89c6).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1893      +/-   ##
==========================================
+ Coverage   21.81%   21.82%   +0.01%     
==========================================
  Files         117      117              
  Lines       18929    18929              
==========================================
+ Hits         4130     4132       +2     
+ Misses      14488    14487       -1     
+ Partials      311      310       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdbranco
Copy link
Contributor

gdbranco commented Apr 1, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2024
Copy link
Contributor

openshift-ci bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gdbranco, tirthct

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c9f520d into openshift:master Apr 1, 2024
9 checks passed
@tirthct tirthct deleted the ocm-6926-fix-mandatory-env branch April 1, 2024 18:13
gdbranco pushed a commit that referenced this pull request Apr 1, 2024
OCM-6926 | fix: Added back the condition to check for empty env flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants