Display AWS Billing Account on non-HCP

[paradigm]

Billing accounts can now be set on ROSA Classic clusters (rather than just HCP clusters) and should be included in rosa describe cluster accordingly.

[openshift-ci]

Hi @paradigm. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cristianoveiga]

LGTM

[ciaranRoche]

@paradigm can you link a JIRA for this change.

You will also need to update the commit message for the CI to pass - https://github.com/openshift/rosa/blob/master/CONTRIBUTING.md

[paradigm]

Jira ticket is: https://issues.redhat.com/browse/OCM-6145

I've updated the commit message format per CONTRIBUTING.md and applied the suggested change to drop the now unnecessary parameter.

[robpblake]

/ok-to-test

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 21.59%. Comparing base (f107b6f) to head (b89464f).
Report is 15 commits behind head on master.

Files	Patch %	Lines
cmd/describe/cluster/cmd.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1894      +/-   ##
==========================================
- Coverage   21.81%   21.59%   -0.23%     
==========================================
  Files         117      117              
  Lines       18929    19387     +458     
==========================================
+ Hits         4130     4187      +57     
- Misses      14488    14886     +398     
- Partials      311      314       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[openshift-ci]

@paradigm: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[robpblake]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paradigm, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [robpblake]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment