Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6161 | ci: Automate HCP machinepool creation with security groups #1898

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

xueli181114
Copy link
Contributor

lixue@Xue-Lis-MacBook-Pro rosa % ginkgo -focus "with additional security group IDs" tests/e2e
Running Suite: e2e tests suite - /Users/lixue/Workspace/rosa/tests/e2e
======================================================================
Random Seed: 1712152071

Will run 1 of 2 specs
time="2024-04-03T21:47:53+08:00" level=info msg="Running command: rosa create machinepool --additional-security-group-ids sg-0497af1a40908d82b,sg-0fff00cf3ca25b0c8,sg-058b2374174cfd370,sg-0f953b1e74639a371 --replicas 1 -y -c 2add20bo15cedljf52rppgq0f52jo3aj --name mp-72195"
time="2024-04-03T21:48:08+08:00" level=info msg="Get Combining Stdout and Stder is :\nINFO: Machine pool 'mp-72195' created successfully on hosted cluster '2add20bo15cedljf52rppgq0f52jo3aj'\nINFO: To view the machine pool details, run 'rosa describe machinepool --cluster 2add20bo15cedljf52rppgq0f52jo3aj --machinepool mp-72195'\nINFO: To view all machine pools, run 'rosa list machinepools --cluster 2add20bo15cedljf52rppgq0f52jo3aj'\n"
time="2024-04-03T21:48:08+08:00" level=info msg="Running command: rosa describe machinepool mp-72195 -c 2add20bo15cedljf52rppgq0f52jo3aj"
time="2024-04-03T21:48:13+08:00" level=info msg="Get Combining Stdout and Stder is :\n\nID:                                    mp-72195\nCluster ID:                            2add20bo15cedljf52rppgq0f52jo3aj\nAutoscaling:                           No\nDesired replicas:                      1\nCurrent replicas:                      0\nInstance type:                         m5.xlarge\nLabels:                                \nTaints:                                \nAvailability zone:                     us-west-2a\nSubnet:                                subnet-06bf16b5b55d68b12\nVersion:                               4.15.6\nAutorepair:                            Yes\nTuning configs:                        \nAdditional security group IDs:         sg-0497af1a40908d82b, sg-0fff00cf3ca25b0c8, sg-058b2374174cfd370, sg-0f953b1e74639a371\nNode drain grace period:               \nMessage:                               WaitingForAvailableMachines\n"
time="2024-04-03T21:48:13+08:00" level=info msg="Running command: rosa create machinepool --replicas 1 -y -c 2add20bo15cedljf52rppgq0f52jo3aj --name mp-72195-nsg"
time="2024-04-03T21:48:26+08:00" level=info msg="Get Combining Stdout and Stder is :\nINFO: Machine pool 'mp-72195-nsg' created successfully on hosted cluster '2add20bo15cedljf52rppgq0f52jo3aj'\nINFO: To view the machine pool details, run 'rosa describe machinepool --cluster 2add20bo15cedljf52rppgq0f52jo3aj --machinepool mp-72195-nsg'\nINFO: To view all machine pools, run 'rosa list machinepools --cluster 2add20bo15cedljf52rppgq0f52jo3aj'\n"
time="2024-04-03T21:48:26+08:00" level=info msg="Running command: rosa describe machinepool mp-72195-nsg -c 2add20bo15cedljf52rppgq0f52jo3aj"
time="2024-04-03T21:48:33+08:00" level=info msg="Get Combining Stdout and Stder is :\n\nID:                                    mp-72195-nsg\nCluster ID:                            2add20bo15cedljf52rppgq0f52jo3aj\nAutoscaling:                           No\nDesired replicas:                      1\nCurrent replicas:                      0\nInstance type:                         m5.xlarge\nLabels:                                \nTaints:                                \nAvailability zone:                     us-west-2a\nSubnet:                                subnet-06bf16b5b55d68b12\nVersion:                               4.15.6\nAutorepair:                            Yes\nTuning configs:                        \nAdditional security group IDs:         \nNode drain grace period:               \nMessage:                               WaitingForAvailableMachines\n"
time="2024-04-03T21:48:33+08:00" level=info msg="Running command: rosa delete machinepool -c 2add20bo15cedljf52rppgq0f52jo3aj mp-72195-nsg -y"
time="2024-04-03T21:48:37+08:00" level=info msg="Get Combining Stdout and Stder is :\nINFO: Successfully deleted machine pool 'mp-72195-nsg' from hosted cluster '2add20bo15cedljf52rppgq0f52jo3aj'\n"
time="2024-04-03T21:48:37+08:00" level=info msg="Running command: rosa delete machinepool -c 2add20bo15cedljf52rppgq0f52jo3aj mp-72195 -y"
time="2024-04-03T21:48:42+08:00" level=info msg="Get Combining Stdout and Stder is :\nINFO: Successfully deleted machine pool 'mp-72195' from hosted cluster '2add20bo15cedljf52rppgq0f52jo3aj'\n"
•S

Ran 1 of 2 Specs in 49.737 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 1 Skipped
You're using deprecated Ginkgo functionality:
=============================================
  --ginkgo.slow-spec-threshold is deprecated --slow-spec-threshold has been deprecated and will be removed in a future version of Ginkgo.  This feature has proved to be more noisy than useful.  You can use --poll-progress-after, instead, to get more actionable feedback about potentially slow specs and understand where they might be getting stuck.

To silence deprecations that can be silenced set the following environment variable:
  ACK_GINKGO_DEPRECATIONS=2.13.0

PASS

Ginkgo ran 1 suite in 51.524559605s
Test Suite Passed

@xueli181114
Copy link
Contributor Author

@yasun1 @oriAdler @radtriste Can you please help to review?

@openshift-ci openshift-ci bot requested review from tzhou5 and yasun1 April 3, 2024 14:01
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.61%. Comparing base (ec4e4a0) to head (559bc37).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1898      +/-   ##
==========================================
- Coverage   21.88%   21.61%   -0.28%     
==========================================
  Files         117      118       +1     
  Lines       18935    19773     +838     
==========================================
+ Hits         4144     4274     +130     
- Misses      14477    15177     +700     
- Partials      314      322       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/e2e/hcp_machine_pool_test.go Outdated Show resolved Hide resolved
tests/e2e/hcp_machine_pool_test.go Outdated Show resolved Hide resolved
tests/e2e/hcp_machine_pool_test.go Outdated Show resolved Hide resolved
tests/e2e/hcp_machine_pool_test.go Outdated Show resolved Hide resolved
tests/e2e/hcp_machine_pool_test.go Outdated Show resolved Hide resolved
tests/e2e/hcp_machine_pool_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

openshift-ci bot commented Apr 7, 2024

@xueli181114: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yasun1
Copy link
Contributor

yasun1 commented Apr 7, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2024
Copy link
Contributor

openshift-ci bot commented Apr 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oriAdler, xueli181114, yasun1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1e65b56 into openshift:master Apr 7, 2024
9 checks passed
@xueli181114 xueli181114 deleted the OCM-6161 branch May 21, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants