-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-6161 | ci: Automate HCP machinepool creation with security groups #1898
Conversation
xueli181114
commented
Apr 3, 2024
@yasun1 @oriAdler @radtriste Can you please help to review? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1898 +/- ##
==========================================
- Coverage 21.88% 21.61% -0.28%
==========================================
Files 117 118 +1
Lines 18935 19773 +838
==========================================
+ Hits 4144 4274 +130
- Misses 14477 15177 +700
- Partials 314 322 +8 ☔ View full report in Codecov by Sentry. |
@xueli181114: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oriAdler, xueli181114, yasun1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |