OCM-6840 | fix: Add json output test for external auth #1899
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1899 +/- ##
==========================================
- Coverage 21.89% 21.16% -0.73%
==========================================
Files 117 118 +1
Lines 18929 19780 +851
==========================================
+ Hits 4144 4187 +43
- Misses 14471 15278 +807
- Partials 314 315 +1 ☔ View full report in Codecov by Sentry. |
|
/approve |
|
@gdbranco hmm not sure why, but it still misses the approved label though |
cmd/list/externalauthprovider/cmd.go
Outdated
| @@ -79,7 +79,7 @@ func runWithRuntime(r *rosa.Runtime, cmd *cobra.Command) error { | |||
| r.Reporter.Errorf("%s", err) | |||
| os.Exit(1) | |||
There was a problem hiding this comment.
@chenz4027 Can we also remove this os.Exit() and return the err instead?
There was a problem hiding this comment.
Sure, @robpblake I'll work on it
There was a problem hiding this comment.
It finally passes all tests. @robpblake Would you mind taking a look?
openshift-ci
bot
added
approved
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: Maggie Chen <magchen@redhat.com> change to error Signed-off-by: Maggie Chen <magchen@redhat.com> change text Signed-off-by: Maggie Chen <magchen@redhat.com>
|
lgtm |
|
/retest |
|
@chenz4027: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chenz4027, ciaranRoche, gdbranco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.