-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-6568 | fix: ensure "mode" in interactive mode defaults to users input #1902
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1902 +/- ##
==========================================
+ Coverage 21.12% 21.58% +0.46%
==========================================
Files 118 118
Lines 19781 19776 -5
==========================================
+ Hits 4178 4269 +91
+ Misses 15289 15186 -103
- Partials 314 321 +7 ☔ View full report in Codecov by Sentry. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciaranRoche, gdbranco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ciaranRoche: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
JIRA - https://issues.redhat.com/browse/OCM-6568
This change sets the default mode to the value the user passes as a param else defaults to true.
Change also converts interactive test to ginkgo and fixes test fails from validation tests.