Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6568 | fix: ensure "mode" in interactive mode defaults to users input #1902

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

ciaranRoche
Copy link
Member

@ciaranRoche ciaranRoche commented Apr 5, 2024

JIRA - https://issues.redhat.com/browse/OCM-6568

This change sets the default mode to the value the user passes as a param else defaults to true.

Change also converts interactive test to ginkgo and fixes test fails from validation tests.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 28.84615% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 21.58%. Comparing base (5935b9c) to head (3c5ed7c).
Report is 2 commits behind head on master.

Files Patch % Lines
cmd/upgrade/roles/cmd.go 4.76% 20 Missing ⚠️
cmd/create/cluster/cmd.go 16.66% 5 Missing ⚠️
cmd/dlt/accountroles/cmd.go 16.66% 5 Missing ⚠️
cmd/upgrade/cluster/cmd.go 33.33% 4 Missing ⚠️
pkg/interactive/mode.go 83.33% 2 Missing ⚠️
pkg/ocm/clusters.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1902      +/-   ##
==========================================
+ Coverage   21.12%   21.58%   +0.46%     
==========================================
  Files         118      118              
  Lines       19781    19776       -5     
==========================================
+ Hits         4178     4269      +91     
+ Misses      15289    15186     -103     
- Partials      314      321       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdbranco
Copy link
Contributor

gdbranco commented Apr 5, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2024
Copy link
Contributor

openshift-ci bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche, gdbranco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ciaranRoche,gdbranco]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ebcb463 and 2 for PR HEAD 3c5ed7c in total

Copy link
Contributor

openshift-ci bot commented Apr 5, 2024

@ciaranRoche: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ade17cc into openshift:master Apr 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants