OCM-5174 | fix: error message should distinguish between labels and taints #1903
Conversation
…aints Error message was mentioning labels even if the issue was on taints. Fix that and improve test coverage. Related: OCM-5174
|
@andreadecorte: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1903 +/- ##
==========================================
+ Coverage 21.12% 21.61% +0.49%
==========================================
Files 118 118
Lines 19781 19773 -8
==========================================
+ Hits 4178 4274 +96
+ Misses 15289 15177 -112
- Partials 314 322 +8 ☔ View full report in Codecov by Sentry. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreadecorte, gdbranco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Error message was mentioning labels even if the issue was on taints.
Fix that and improve test coverage.
Related: OCM-5174