Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6501 | fix: Adjust describe machine pool output #1927

Merged
merged 1 commit into from Apr 15, 2024

Conversation

oriAdler
Copy link
Contributor

Change to additional security groups ids to match the flag name.

e.g.

oadler@fedora:rosa (OCM-6501)$ rosa describe machinepool -c croche worker

ID:                                    worker
Cluster ID:                            2ai5ok6qebvc8jk442pnsoci2ob00fmn
Autoscaling:                           No
Replicas:                              2
Instance type:                         m5.xlarge
Labels:                                
Taints:                                
Availability zones:                    eu-west-1a
Subnets:                               
Spot instances:                        No
Disk size:                             300 GiB
Additional Security Group IDs:         123

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2024
@oriAdler oriAdler force-pushed the OCM-6501 branch 2 times, most recently from 5e0a5a9 to 6455328 Compare April 15, 2024 09:01
Change to additional security groups ids to match the flag name.
Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

@oriAdler: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.69%. Comparing base (3159d23) to head (6455328).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1927   +/-   ##
=======================================
  Coverage   21.69%   21.69%           
=======================================
  Files         118      118           
  Lines       19797    19797           
=======================================
  Hits         4294     4294           
  Misses      15181    15181           
  Partials      322      322           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@robpblake robpblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2024
Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oriAdler, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2eaeea7 into openshift:master Apr 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants